After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692393 - Simplify finalize functions
Simplify finalize functions
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: gnome-session
unspecified
Other All
: Normal normal
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-01-23 15:00 UTC by Bastien Nocera
Modified: 2013-01-23 15:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fail-whale-dialog: Remove chained-up finalize function (1.41 KB, patch)
2013-01-23 15:00 UTC, Bastien Nocera 		committed Details | Review
inhibit-dialog: Remove chained-up finalize function (1.99 KB, patch)
2013-01-23 15:00 UTC, Bastien Nocera 		committed Details | Review
manager: Remove chained-up finalize function (1.81 KB, patch)
2013-01-23 15:00 UTC, Bastien Nocera 		committed Details | Review
presence: Simplify finalize function (1.19 KB, patch)
2013-01-23 15:00 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2013-01-23 15:00:07 UTC 
.
Comment 1 Bastien Nocera 2013-01-23 15:00:09 UTC 
Created attachment 234208 [details] [review]
fail-whale-dialog: Remove chained-up finalize function
Comment 2 Bastien Nocera 2013-01-23 15:00:12 UTC 
Created attachment 234209 [details] [review]
inhibit-dialog: Remove chained-up finalize function
Comment 3 Bastien Nocera 2013-01-23 15:00:15 UTC 
Created attachment 234210 [details] [review]
manager: Remove chained-up finalize function
Comment 4 Bastien Nocera 2013-01-23 15:00:18 UTC 
Created attachment 234211 [details] [review]
presence: Simplify finalize function
Comment 5 Colin Walters 2013-01-23 15:03:21 UTC 
Review of attachment 234208 [details] [review]:

Sure.  I probably would have made these all one patch, but hey, I'm happy to bump my reviewed patches count =)
Comment 6 Colin Walters 2013-01-23 15:03:38 UTC 
Review of attachment 234209 [details] [review]:

Right.
Comment 7 Colin Walters 2013-01-23 15:03:57 UTC 
Review of attachment 234210 [details] [review]:

Ah, copy & paste...
Comment 8 Colin Walters 2013-01-23 15:04:19 UTC 
Review of attachment 234211 [details] [review]:

Looks good.
Comment 9 Bastien Nocera 2013-01-23 15:57:25 UTC 
Attachment 234208 [details] pushed as 0361447 - fail-whale-dialog: Remove chained-up finalize function
Attachment 234209 [details] pushed as 8b2b17d - inhibit-dialog: Remove chained-up finalize function
Attachment 234210 [details] pushed as bea1d16 - manager: Remove chained-up finalize function
Attachment 234211 [details] pushed as 784163c - presence: Simplify finalize function