After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692312 - codecparsers: vc1: fix bitplanes decoding
codecparsers: vc1: fix bitplanes decoding
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.0.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-01-22 17:24 UTC by Gwenole Beauchesne
Modified: 2013-01-25 00:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
codecparsers: vc1: fix bitplanes decoding (1.78 KB, patch)
2013-01-22 17:24 UTC, Gwenole Beauchesne 		committed Details | Review

Description Gwenole Beauchesne 2013-01-22 17:24:43 UTC 
Created attachment 234121 [details] [review]
codecparsers: vc1: fix bitplanes decoding

Hi, this patch fixes decoding of DIFF2 or NORM2 bitplanes with an odd number of macroblocks. In particular, we need to account for the first bit that was already parsed so that to avoid a buffer overflow after all pairs are parsed.
    
This fixes SA00040.vc1 conformance test with gstreamer-vaapi.

I plan to push this patch to gst-plugins-bad 0.10 and 1.0 branches too. Thanks.
Comment 1 Tim-Philipp Müller 2013-01-24 23:04:51 UTC 
commit 82200d75ae1542922ec7f52f6ab7ba7746eebe67
Author: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Date:   Tue Jan 22 18:01:24 2013 +0100

    codecparsers: vc1: fix bitplanes decoding.
    
    Fix decoding of DIFF2 or NORM2 bitplanes with an odd number of macroblocks.
    In particular, account for the first bit that was already parsed so that to
    avoid a buffer overflow after all pairs are parsed.
    
    This fixes SA00040.vc1 conformance test.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=692312
    
    Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>