GNOME Bugzilla – Bug 691965
power: Fix blanking not working
Last modified: 2013-01-22 08:23:43 UTC
.
Created attachment 233680 [details] [review] power: Fix blanking not working When we got the ActiveChanged() signal from gnome-shell's screen lock, we would reconfigure the blank time out to be much shorter. The problem is that the timeout is based on idleness, and we would already have been past that amount of idleness when we setup the new idle monitor. Instead of basing ourselves on idle timeouts, just wait for the screensaver to come on. Once it comes on, we'll do the initial blanking after the expected fade timeout, and handle idleness as expected (so it's possible to cancel the login, and have the screen be blanked quickly).
Created attachment 233681 [details] [review] power: Fix blanking not working (if gnome-shell's ActiveChanged gets fixed) When we got the ActiveChanged() signal from gnome-shell's screen lock, we would reconfigure the blank time out to be much shorter. The problem is that the timeout is based on idleness, and we would already have been past that amount of idleness when we setup the new idle monitor. Instead of basing ourselves on idle timeouts, just wait for the screensaver to come on and blank it. We'll handle idleness as normal (so it's possible to cancel the login, and have the screen be blanked quickly).
Created attachment 233694 [details] [review] power: Fix blanking not working When we got the ActiveChanged() signal from gnome-shell's screen lock, we would reconfigure the blank time out to be much shorter. The problem is that the timeout is based on idleness, and we would already have been past that amount of idleness when we setup the new idle monitor. Instead of basing ourselves on idle timeouts, just wait for the screensaver to come on. Once it comes on, we'll do the initial blanking after the expected fade timeout, and handle idleness as expected (so it's possible to cancel the login, and have the screen be blanked quickly).
Comment on attachment 233680 [details] [review] power: Fix blanking not working Was missing the "if (active)" line.
Created attachment 234016 [details] [review] power: Fix blanking not working (if gnome-shell's ActiveChanged gets fixed) When we got the ActiveChanged() signal from gnome-shell's screen lock, we would reconfigure the blank time out to be much shorter. The problem is that the timeout is based on idleness, and we would already have been past that amount of idleness when we setup the new idle monitor. Instead of basing ourselves on idle timeouts, just wait for the screensaver to come on and blank it. We'll handle idleness as normal (so it's possible to cancel the login, and have the screen be blanked quickly).
Created attachment 234045 [details] [review] power: Fix blanking not working When we got the ActiveChanged() signal from gnome-shell's screen lock, we would reconfigure the blank time out to be much shorter. The problem is that the timeout is based on idleness, and we would already have been past that amount of idleness when we setup the new idle monitor. Instead of basing ourselves on idle timeouts, just wait for the screensaver to come on and blank it. We'll handle idleness as normal (so it's possible to cancel the login, and have the screen be blanked quickly).
I've pushed this as carrying this patch when running test cases is getting to be too much of a trouble. We'll *need* to have gnome-shell fixed before the 3.7.5 release. Attachment 234045 [details] pushed as e0e50ea - power: Fix blanking not working