After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691962 - sharing: add helper application to enable or disable remote login
sharing: add helper application to enable or disable remote login
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Sharing
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-01-17 17:32 UTC by Thomas Wood
Modified: 2013-01-18 18:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
sharing: add helper application to enable or disable remote login (13.41 KB, patch)
2013-01-17 17:32 UTC, Thomas Wood 		committed Details | Review

Description Thomas Wood 2013-01-17 17:32:48 UTC 
Add a helper application and PolicyKit action to enable, disable the remote login (ssh) service.
Comment 1 Thomas Wood 2013-01-17 17:32:50 UTC 
Created attachment 233678 [details] [review]
sharing: add helper application to enable or disable remote login
Comment 2 Bastien Nocera 2013-01-18 15:08:09 UTC 
Review of attachment 233678 [details] [review]:

::: panels/sharing/cc-remote-login-helper.c
@@ +119,3 @@
+                                              NULL,
+                                              &error);
+  if (error)

if (temp_variant)

@@ +126,3 @@
+    }
+  g_variant_unref (temp_variant);
+

Remove extraneous linefeeds.

@@ +143,3 @@
+                                              &error);
+
+  if (error)

if (temp_variant == NULL)

@@ +155,3 @@
+
+}
+

single line-feed

::: panels/sharing/cc-remote-login.c
@@ +155,3 @@
+      cc_remote_login_get_enabled (GTK_SWITCH (gtkswitch));
+    }
+  g_spawn_close_pid (pid);

And make switch sensitive here.

@@ +176,3 @@
+    command[2] = "enable";
+  else
+    command[2] = "disable";

make the switch insensitive here.
Comment 3 Thomas Wood 2013-01-18 18:26:48 UTC 
Attachment 233678 [details] pushed as 0999c4a - sharing: add helper application to enable or disable remote login