After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691944 - superfluous libdl
superfluous libdl
Status: RESOLVED FIXED
Product: cogl
Classification: Platform
Component: general
git master
Other NetBSD
: Normal normal
: ---
Assigned To: Cogl maintainer(s)
Cogl maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-01-17 12:37 UTC by Patrick Welche
Modified: 2013-01-22 17:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
remove -ldl / #include dlfcn.h (1.06 KB, patch)
2013-01-17 12:37 UTC, Patrick Welche 		none Details | Review

Description Patrick Welche 2013-01-17 12:37:53 UTC 
Created attachment 233665 [details] [review]
remove -ldl / #include dlfcn.h

libdl and dlfcn.h define dlopen() and friends. AFAICT they are not used anywhere in the cogl code - maybe a vestige from pre-gmodule days?

I think it is worth removing references to them as e.g., cogl/Makefile.am

  if SUPPORT_GLX
  libcogl2_la_LIBADD += -ldl
  endif

tries to link against libdl even on systems which have dlopen() in libc.
Comment 1 Neil Roberts 2013-01-22 17:46:50 UTC 
Thanks for the patch. I've pushed it to master and the 1.12 branch. We'll also be sure to backport it to the 1.14 branch.