GNOME Bugzilla – Bug 691916
sharing: whitespace issues
Last modified: 2013-01-22 12:07:50 UTC
There is too little space between 'Computer Name' and the entry. It is also somewhat unusual to put the label above the entry; I don't think we do that anywhere else. All the popups have issues with too little left and right padding. All the popups have issues with alignment between close button and content. The popups shouldn't be resizable. There should be at least 6 pixels of padding between labels and their controls. The screen sharing popup should be wider, it is too tall and narrow. The file chooser on top of the media sharing popup is much too small.
Created attachment 233749 [details] [review] sharing: address padding and alignment issues in the dialogs Increase the padding around the dialog content, fix the alignment between the close button and content and add padding between labels and their controls. Also ensure the dialogs are not resizable. This patch address all of the above concerns, except for the first issue and the last two issues. I think the first one will need some design input. The last two are concerned with dialog sizing, but I am unsure exactly how the minimum size for the dialogs should be determined.
Comment on attachment 233749 [details] [review] sharing: address padding and alignment issues in the dialogs Commit 0dec964 pushed that addresses the above issues, except for the file chooser dialog size, which is possibly a bug in GTK+. The issue with the screen sharing dialog being too tall and narrow appears to have been fixed by setting the dialog as non-resizable.
The file chooser sizing issue has been confirmed as a GTK+ bug and since all the other issues in this bug have been resolved, I'm marking it as fixed.