After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691874 - window-actor: Speed up mask creation
window-actor: Speed up mask creation
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2013-01-16 17:12 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-01-17 21:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
window-actor: Rename variable in scanning function (1.44 KB, patch)
2013-01-16 17:12 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
window-actor: Speed up mask creation (1.20 KB, patch)
2013-01-16 17:12 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-01-16 17:12:40 UTC 
A set of typos made us try to union a bunch of bogus rects
for every pixel.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-01-16 17:12:42 UTC 
Created attachment 233612 [details] [review]
window-actor: Rename variable in scanning function

"w" usually stands for "width", but here it stands for the end X bound,
so we'll rename it to the more traditional "x2".
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-01-16 17:12:44 UTC 
Created attachment 233613 [details] [review]
window-actor: Speed up mask creation

Due to a conditional error, meta_region_builder_add_rectangle was called
on every single blank pixel, rather than at the end of spans. With the new
rename, it's fairly clear to see the error. Fix the check to ensure that
we no longer make extraneous calls to meta_region_builder_add_rectangle.
Comment 3 Owen Taylor 2013-01-17 21:24:31 UTC 
Review of attachment 233612 [details] [review]:

OK
Comment 4 Owen Taylor 2013-01-17 21:24:44 UTC 
Review of attachment 233613 [details] [review]:

Good catch
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-01-17 21:34:09 UTC 
Attachment 233612 [details] pushed as 95f3bb3 - window-actor: Rename variable in scanning function
Attachment 233613 [details] pushed as 5d12f00 - window-actor: Speed up mask creation