After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691866 - fails out of source build directory - gnetwork.h not found
fails out of source build directory - gnetwork.h not found
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: build
2.35.x
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2013-01-16 15:58 UTC by Alban Browaeys
Modified: 2013-01-23 17:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gio: Fixes out of source build directory. (746 bytes, patch)
2013-01-16 15:58 UTC, Alban Browaeys 		none Details | Review
build: fix a srcdir != builddir problem with gnetworking.h (2.20 KB, patch)
2013-01-21 16:40 UTC, Dan Winship 		committed Details | Review

Description Alban Browaeys 2013-01-16 15:58:34 UTC 
Created attachment 233608 [details] [review]
gio: Fixes out of source build directory.

glib-mkenums is ran from srcdir, thus generated gnetworking.h
needs to be provided via abs_builddir.
Comment 1 Dan Winship 2013-01-21 16:40:09 UTC 
Created attachment 234025 [details] [review]
build: fix a srcdir != builddir problem with gnetworking.h

gio's glib-mkenums call needs to get gnetworking.h out of $(builddir),
not $(srcdir). Fix/simplify it by using $(filter) on $^ and letting
make find everything.

Also add -Wno-portability to AM_INIT_AUTOMAKE in configure.ac, so that
it doesn't warn about this (or about the gmake-specific features we
were already using in gio/tests/)
Comment 2 Dan Winship 2013-01-21 16:40:45 UTC 
Comment on attachment 233608 [details] [review]
gio: Fixes out of source build directory.

>-	gnetworking.h		\
>+	$(abs_builddir)/gnetworking.h	\

this is pretty ugly... I've attached an alternate approach
Comment 3 Alban Browaeys 2013-01-21 20:34:27 UTC 
Thanks indeed it was ugly though my fu was not up to this issue. Thanks for the fix which works well.
Comment 4 Dan Winship 2013-01-23 17:51:07 UTC 
Attachment 234025 [details] pushed as 455afd3 - build: fix a srcdir != builddir problem with gnetworking.h