After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691733 - notifications - list is too wide
notifications - list is too wide
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Notifications
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Marek Kašík
Control-Center Maintainers
3.10
Depends on:
Blocks:
 
 
Reported: 2013-01-14 19:37 UTC by Allan Day
Modified: 2013-07-31 15:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshots (353.76 KB, image/png)
2013-01-14 19:37 UTC, Allan Day 		  Details
notifications: to shrink the list (2.44 KB, patch)
2013-07-30 18:54 UTC, Yosef Or Boczko 		needs-work Details | Review
Screenshot (91.39 KB, image/png)
2013-07-30 18:59 UTC, Yosef Or Boczko 		  Details
notifications: to shrink the list (1.46 KB, patch)
2013-07-31 15:46 UTC, Yosef Or Boczko 		committed Details | Review

Description Allan Day 2013-01-14 19:37:43 UTC 
Created attachment 233464 [details]
screenshots

The list is too wide. This has a few consequences:

 * The labels and switches at the top of the list are too far away from each other
 * The application name is too far from the "On"/"Off" label
 * It is inconsistent with many of the other panels (see the attached screenshot)
Comment 1 António Fernandes 2013-02-14 12:25:39 UTC 
I think this valid for Color and Power panels as well.
Comment 2 Bastien Nocera 2013-04-19 14:44:10 UTC 
(In reply to comment #1)
> I think this valid for Color and Power panels as well.

Please file separate bugs for those.
Comment 3 António Fernandes 2013-04-19 15:06:25 UTC 
(In reply to comment #2)
> Please file separate bugs for those.

Done: bug 698372 & bug 698373
Comment 4 Yosef Or Boczko 2013-07-30 18:54:15 UTC 
Created attachment 250499 [details] [review]
notifications: to shrink the list

It is inconsistent with many of the other panels:
134px in left-hand side of the list, 134px in right-hand side of the list,
22px from on bottom of the list and 22px from on top of the list.
Comment 5 Yosef Or Boczko 2013-07-30 18:59:17 UTC 
Created attachment 250501 [details]
Screenshot
Comment 6 Bastien Nocera 2013-07-31 15:03:08 UTC 
Review of attachment 250499 [details] [review]:

Rest looks fine, as long as the designers are happy with it.

::: panels/notifications/notifications.ui
@@ +1,2 @@
 <?xml version="1.0" encoding="UTF-8"?>
+<!-- Generated with glade 3.15.2 on Tue Jul 30 21:38:10 2013 -->

Can you remove some of the unneeded changes? So, this one.

@@ +80,2 @@
             <property name="hscrollbar_policy">never</property>
+            <property name="shadow_type">in</property>

This, because it didn't actually change from the original, just moved.
Comment 7 Yosef Or Boczko 2013-07-31 15:04:24 UTC 
Yes. each the changes this glade generated...
Comment 8 Yosef Or Boczko 2013-07-31 15:46:05 UTC 
Created attachment 250556 [details] [review]
notifications: to shrink the list
Comment 9 Bastien Nocera 2013-07-31 15:51:01 UTC 
Review of attachment 250556 [details] [review]:

Looks good.
Comment 10 Yosef Or Boczko 2013-07-31 15:52:52 UTC 
Review of attachment 250556 [details] [review]:

pushed as 220282ffd7f9d2a171351dac9a41a630a2275b2d - notifications: to shrink the list