After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691719 - object: Force signal detail quark creation on signal connections
object: Force signal detail quark creation on signal connections
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2013-01-14 15:14 UTC by Rui Matos
Modified: 2013-01-14 15:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
object: Force signal detail quark creation on signal connections (1.20 KB, patch)
2013-01-14 15:14 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2013-01-14 15:14:54 UTC 
See patch.
Comment 1 Rui Matos 2013-01-14 15:14:56 UTC 
Created attachment 233448 [details] [review]
object: Force signal detail quark creation on signal connections

Otherwise handlers for detailed signals will always get called even
when the detail doesn't match the emited one.

This used to work before because g_signal_connect_closure() forces the
detail quark creation implicitly, but since we switched to
g_signal_connect_closure_by_id(), this is the right thing to do.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-01-14 15:23:20 UTC 
Review of attachment 233448 [details] [review]:

OK.
Comment 3 Rui Matos 2013-01-14 15:30:19 UTC 
Attachment 233448 [details] pushed as 19784d7 - object: Force signal detail quark creation on signal connections