After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691646 - Fix testsuite with python 2.6
Fix testsuite with python 2.6
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: general
3.4.x
Other Linux
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2013-01-13 11:43 UTC by Gilles Dartiguelongue
Modified: 2013-01-14 07:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
pygobject-3.4.2-run-tests-with-old-python.patch (5.15 KB, patch)
2013-01-13 11:43 UTC, Gilles Dartiguelongue 		rejected Details | Review

Description Gilles Dartiguelongue 2013-01-13 11:43:44 UTC 
Created attachment 233370 [details] [review]
pygobject-3.4.2-run-tests-with-old-python.patch

It looks like current hacks to make the testsuite run with python 2.6 are not working so well.

First, it looks like some people added more code that needs a more recent unittest (assertLessEqual)

Second, it looks like the skipUnless hack makes the testsuite return with exit code 1 which is not desirable.

So here is a simple patch that makes use of official unittest backport for older python where needed.
Comment 1 Martin Pitt 2013-01-14 06:02:12 UTC 
Comment on attachment 233370 [details] [review]
pygobject-3.4.2-run-tests-with-old-python.patch

To be honest I'm not a fan of introducing another dependency (unittest2) which might not even be available everywhere. I'd rather add the missing backwards compat stubs.

We won't support Python 2.6 for a long time any more anyway.
Comment 3 Gilles Dartiguelongue 2013-01-14 07:50:14 UTC 
One way or another, if it fixes the testsuite, then that makes me happy.
Thanks for handling it quickly.