After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691578 - On application hover: corners are not rounded enough on application view in the dash.
On application hover: corners are not rounded enough on application view in t...
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Low enhancement
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-01-11 19:49 UTC by Marco Scannadinari
Modified: 2013-08-26 18:59 UTC
See Also:
GNOME target: ---
GNOME version: 3.5/3.6


Attachments
Added border radius to application icons in the grid on hover (777 bytes, patch)
2013-03-04 15:26 UTC, bharath
none Details | Review
Added border radius for icons in application grid and not in dash (935 bytes, patch)
2013-03-04 18:03 UTC, bharath
none Details | Review
Added border radius for icons in application grid and not in dash (704 bytes, patch)
2013-03-04 18:17 UTC, bharath
none Details | Review
updated patch (985 bytes, patch)
2013-03-07 12:52 UTC, Allan Day
committed Details | Review
theme: Adjust border-radius for focus indication to match hover (1.04 KB, patch)
2013-03-14 22:34 UTC, Florian Müllner
committed Details | Review
same border radius for app picker and search result icons (1.99 KB, patch)
2013-08-26 18:59 UTC, florian-baeuerle
none Details | Review

Description Marco Scannadinari 2013-01-11 19:49:34 UTC
Dodgy:
http://i50.tinypic.com/2z6fj0g.png
Fine:
http://i47.tinypic.com/ziunpc.png

I believe you can see what the difference is in those two screenshots - the highlight when hovered over an application is two large, or its corners are too sharp on the 1st one, and the devs have probrably just used that same image for both of them.
This is not a software bug!
Comment 1 Hashem Nasarat 2013-01-23 06:24:07 UTC
I don't see the difference between the two photos, but I agree that having more rounded corners would look better.
Comment 2 Allan Day 2013-01-23 09:48:51 UTC
Good catch - the border radius doesn't match the radius of the running indicator in the app view.

Looking at the css, it seems that we have a single style class for all the app icons. I suspect that we'll need a separate style class for the app icons in the app view as opposed to the dash.
Comment 3 Marco Scannadinari 2013-01-25 10:40:03 UTC
(In reply to comment #2)
> Good catch - the border radius doesn't match the radius of the running
> indicator in the app view.
> 
> Looking at the css, it seems that we have a single style class for all the app
> icons. I suspect that we'll need a separate style class for the app icons in
> the app view as opposed to the dash.

Hm, I was just going to submit this to every detail matters but it appears it has caught your attention already. Do you know if a dev is working on this?
Comment 4 bharath 2013-02-26 18:35:50 UTC
I am interested to work on this bug
Comment 5 bharath 2013-03-04 15:26:25 UTC
Created attachment 237997 [details] [review]
Added border radius to application icons in the grid on hover
Comment 6 bharath 2013-03-04 18:03:36 UTC
Created attachment 238026 [details] [review]
Added border radius for icons in application grid and not in dash
Comment 7 Jasper St. Pierre (not reading bugmail) 2013-03-04 18:08:18 UTC
Can you squash these two fixes together?
Comment 8 bharath 2013-03-04 18:17:47 UTC
Created attachment 238027 [details] [review]
Added border radius for icons in application grid and not in dash
Comment 9 Allan Day 2013-03-07 12:52:38 UTC
Created attachment 238286 [details] [review]
updated patch

This looks good to me. Thanks!

I had to respin the patch because it didn't apply.
Comment 10 Allan Day 2013-03-07 13:02:04 UTC
Thanks for the fix, Bharath!
Comment 11 Florian Müllner 2013-03-14 22:34:38 UTC
Created attachment 238940 [details] [review]
theme: Adjust border-radius for focus indication to match hover

Commit 7b3a689aadd changed the border-radius of the hover effect
to match the prelight effect, but not the focus indication, so
the focused item now changes corners on hover. Fix this by using
a consistent border-radius.
Comment 12 Jasper St. Pierre (not reading bugmail) 2013-03-14 22:48:55 UTC
Review of attachment 238940 [details] [review]:

Can we just make the border-radius always exist instead of special-casing hover and focus?
Comment 13 Florian Müllner 2013-03-14 23:05:01 UTC
Attachment 238940 [details] pushed as 603f528 - theme: Adjust border-radius for focus indication to match hover

(In reply to comment #12)
> Can we just make the border-radius always exist instead of special-casing hover
> and focus?

Sure ...
Comment 14 Mantas Mikulėnas (grawity) 2013-03-20 15:01:44 UTC
It seems that the app search results still have the old, smaller border-radius.(Which means it's now different between app search and app picker too.)
Comment 15 florian-baeuerle 2013-08-26 18:59:45 UTC
Created attachment 253166 [details] [review]
same border radius for app picker and search result icons

This patch gives the old 4px border-radius to the dash icons, new 10px to app search results and app picker icons and 5px to the search-provider-icon and the list-search-results.