After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691572 - Touch: strengthen synthesized touch crossing events machinery against programmatic crossings
Touch: strengthen synthesized touch crossing events machinery against program...
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Class: GdkDevice
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
Carlos Garnacho
Depends on:
Blocks:
 
 
Reported: 2013-01-11 18:07 UTC by Carlos Garnacho
Modified: 2013-01-15 16:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (2.18 KB, patch)
2013-01-11 18:08 UTC, Carlos Garnacho 		accepted-commit_now Details | Review

Description Carlos Garnacho 2013-01-11 18:07:07 UTC 
There are cases where X sends crossing events with deviceid=sourceid, specially around moving/disappearing windows when the pointer is on top. 

Gdk already does some business at setting a meaningful source device on those events, but that's unfortunately confusing the machinery that blocks/synthesizes crossing events for touch devices, which may lead to extra enter/leave events in those cases that are unwanted after interacting with a touch device.

I'm attaching a patch to fix that
Comment 1 Carlos Garnacho 2013-01-11 18:08:32 UTC 
Created attachment 233256 [details] [review]
patch
Comment 2 Matthias Clasen 2013-01-12 14:41:16 UTC 
Review of attachment 233256 [details] [review]:

I'll have to trust you on this one, I don't have a touch device available here atm.
Comment 3 Carlos Garnacho 2013-01-15 16:54:22 UTC 
Thanks, the patch is now on master and gtk-3-6. It indeed helped fix an issue on sugar, I'll leave http://bugs.sugarlabs.org/ticket/4068#comment:9 for reference there, this patch is the last iteration on that bug.