GNOME Bugzilla – Bug 691548
missing xmlFree in xsltCompileIdKeyPattern
Last modified: 2013-08-05 11:09:19 UTC
Hi, While reviewing some change in xsltCompileIdKeyPattern, I noticed that there might be missing xmlFree: current git source from line 1453: } else if (xmlStrEqual(name, (const xmlChar *)"processing-instruction")) { NEXT; SKIP_BLANKS; if (CUR != ')') { lit = xsltScanLiteral(ctxt); if (ctxt->error) { xsltTransformError(NULL, NULL, NULL, "xsltCompileIdKeyPattern : Literal expected\n"); return; } SKIP_BLANKS; if (CUR != ')') { xsltTransformError(NULL, NULL, NULL, "xsltCompileIdKeyPattern : ) expected\n"); ctxt->error = 1; !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! return; } Instead of the exclamation marks I believe there should be xmlFree(lit); I have no reproducible case or anything, it's just pure observation of the code, so I might be wrong.
Fixed in commit a976434b. Thanks for the report.