After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691485 - symbol-db: Add update_flag to the symbol unique constraint.
symbol-db: Add update_flag to the symbol unique constraint.
Status: RESOLVED FIXED
Product: anjuta
Classification: Applications
Component: plugins: symbol-db
unspecified
Other All
: Normal normal
: ---
Assigned To: Massimo Cora'
Anjuta maintainers
Depends on:
Blocks:
 
 
Reported: 2013-01-10 17:02 UTC by Carl-Anton Ingmarsson
Modified: 2013-01-12 15:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
symbol-db: Add update_flag to the symbol unique constraint. (1.99 KB, patch)
2013-01-10 17:02 UTC, Carl-Anton Ingmarsson 		committed Details | Review

Description Carl-Anton Ingmarsson 2013-01-10 17:02:04 UTC 
See attached patch.
Comment 1 Carl-Anton Ingmarsson 2013-01-10 17:02:06 UTC 
Created attachment 233161 [details] [review]
symbol-db: Add update_flag to the symbol unique constraint.

When inserting/updating symbols we only care that the symbol is unique among the
symbols that will be kept after all insertions/updates are done, eg. the symbols
whose update_flag is 1.

This should fix the following warning from appearing:
(anjuta:5183): libanjuta-symbol-db-WARNING **: SQL execute_non_select failed:
columns name, file_defined_id, file_position are not unique
Comment 2 Johannes Schmid 2013-01-12 14:27:41 UTC 
Review of attachment 233161 [details] [review]:

Looks good to me and as you updated the database version that should be transparent to the user.
Comment 3 Carl-Anton Ingmarsson 2013-01-12 15:11:38 UTC 
Attachment 233161 [details] pushed as 9d5ecb1 - symbol-db: Add update_flag to the symbol unique constraint.