After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691413 - schemas: Add a 'per-window' key to the input sources schema
schemas: Add a 'per-window' key to the input sources schema
Status: RESOLVED FIXED
Product: gsettings-desktop-schemas
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gsettings-desktop-schemas-maint
gsettings-desktop-schemas-maint
Depends on:
Blocks: 684210 691414
 
 
Reported: 2013-01-09 13:20 UTC by Rui Matos
Modified: 2013-01-09 17:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
schemas: Add a 'per-window' key to the input sources schema (869 bytes, patch)
2013-01-09 13:20 UTC, Rui Matos 		needs-work Details | Review
schemas: Add a 'per-window' key to the input sources schema (1.07 KB, patch)
2013-01-09 17:48 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2013-01-09 13:20:49 UTC 
Simple patch attached.
Comment 1 Rui Matos 2013-01-09 13:20:52 UTC 
Created attachment 233065 [details] [review]
schemas: Add a 'per-window' key to the input sources schema
Comment 2 Bastien Nocera 2013-01-09 17:31:33 UTC 
Review of attachment 233065 [details] [review]:

::: schemas/org.gnome.desktop.input-sources.gschema.xml.in.in
@@ +43,3 @@
     </key>
+    <key name="per-window" type="b">
+      <default>false</default>

Can you add a description though?
Comment 3 Rui Matos 2013-01-09 17:48:44 UTC 
Created attachment 233093 [details] [review]
schemas: Add a 'per-window' key to the input sources schema

--

Sure, here's with a summary and description.
Comment 4 Bastien Nocera 2013-01-09 17:50:47 UTC 
Review of attachment 233093 [details] [review]:

++

::: schemas/org.gnome.desktop.input-sources.gschema.xml.in.in
@@ +44,3 @@
+    <key name="per-window" type="b">
+      <default>false</default>
+      <_summary>Use different sources for each window</_summary>

I'd write "input sources" rather than just "sources" here.
Comment 5 Rui Matos 2013-01-09 17:58:10 UTC 
Amended and pushed.

Attachment 233093 [details] pushed as b1349f6 - schemas: Add a 'per-window' key to the input sources schema