After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691382 - Restore tests disabled by bug #668415 (which has been fixed)
Restore tests disabled by bug #668415 (which has been fixed)
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: e-d-s backend
git master
Other Linux
: Normal normal
: Unset
Assigned To: folks-maint
folks-maint
Depends on:
Blocks:
 
 
Reported: 2013-01-09 05:15 UTC by Travis Reitter
Modified: 2013-01-10 01:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove change-primary-store test, restore and update store-removed test (9.92 KB, patch)
2013-01-09 05:20 UTC, Travis Reitter 		accepted-commit_now Details | Review

Description Travis Reitter 2013-01-09 05:15:44 UTC 
When we filed bug #668415, we disabled a couple EDS tests. Now that the bug is fixed, we should restore these tests.
Comment 1 Travis Reitter 2013-01-09 05:20:30 UTC 
Created attachment 233038 [details] [review]
Remove change-primary-store test, restore and update store-removed test

Patch from branch:

http://cgit.collabora.com/git/user/treitter/folks.git/log/?h=bgo691382-restore-tests
Comment 2 Philip Withnall 2013-01-09 21:48:21 UTC 
Review of attachment 233038 [details] [review]:

Looks good to me.
Comment 3 Travis Reitter 2013-01-10 01:50:58 UTC 
Merged:

commit 321927a49b34febe9d6a995cb0f1839c3f5fff68
Author: Travis Reitter <travis.reitter@collabora.co.uk>
Date:   Sun Jan 6 22:27:27 2013 -0800

    Bug 691382 — Restore tests disabled by bug #668415 (which has been fixed)
    
    This ports the store-removed test to the current EDS introspection bindings
    and removes the change-primary-store test on the basis that we don't really
    support clients changing the primary store.
    
    In the future, we may want to add a test to ensure we cope with the primary
    store disappearing, but that's a different case.
    
    Closes: https://bugzilla.gnome.org/show_bug.cgi?id=691382

 NEWS                                |   1 +
 tests/eds/Makefile.am               |  25 ++----
 tests/eds/change-primary-store.vala | 146 ------------------------------------
 tests/eds/store-removed.vala        |  20 ++---
 tests/lib/eds/backend.vala          |   5 +-
 5 files changed, 16 insertions(+), 181 deletions(-)