Review of attachment 232813 [details] [review]:

Hi Daniel

Thanks for the patch!

::: data/ghex.desktop.in
@@ +3,3 @@
 _GenericName=Hex Editor
 _Comment=Inspect and edit binary files
+_Keywords=hexadecimal;octal;debug;

Looking at the search behaviour of the current gnome-shell version in rawhide, it seems to match the words in Name and GenericName, but not those in Comment. So "Hex" and "Editor" already appear to be implicit keywords.

I'd rather not add "octal" as a keyword, it seems very unlikely that anyone would use that to search for GHex. Instead, a good keyword might be "binary", although that could be hard to translate -- in here it wouldn't mean the 2-base numeric system, but rather data that is not text. Compare "text editor" and "binary file editor". http://en.wikipedia.org/wiki/Binary_file

Is it possible to add translator comments in desktop files, to explain what "binary" means here?

Created attachment 233508 [details] [review]
Updated patch

I agree with you about the "binary" keyword.

I've updated the patch and added a comment to the .desktop file (I've tested it and intltool recognises it properly, and comment appears in the PO file).

Thanks for your review :)

Review of attachment 233508 [details] [review]:

::: data/ghex.desktop.in
@@ +3,3 @@
 _GenericName=Hex Editor
 _Comment=Inspect and edit binary files
+#TRANSLATORS: here, 'binary' means the 2-base numeric system

I was trying to say earlier that binary here would mean 'binary file' as opposed to 'text file', and NOT the 2-base numeric system.

http://en.wikipedia.org/wiki/Binary_file

Besides the comment I think it looks great, thanks!

Oh, sorry, my mistake.

It's ok to commit changing the comment to this one: "here, 'binay' means a binary file (not the base-2 numeric system)"?

Yes, perfect. Thanks!

Done, thanks!