After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691059 - window: fix TabsNext/TabsNextPrevious.
window: fix TabsNext/TabsNextPrevious.
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-01-03 10:09 UTC by Alban Browaeys
Modified: 2013-01-14 17:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
window: fix TabsNext/TabsNextPrevious. (1.74 KB, patch)
2013-01-03 10:09 UTC, Alban Browaeys 		rejected Details | Review

Description Alban Browaeys 2013-01-03 10:09:11 UTC 
Created attachment 232620 [details] [review]
window: fix TabsNext/TabsNextPrevious.

As spotted byt the FIXME comment, the gtk binding is specific to
GtkNotebook. Uses gtk_notebook_set_current_page to switch pages,
from idea that we do only tabs next/previous inside
a TerminalNotebook.
----------
The behaviour is not perfect, though the ability to switch tabs is restored.
Ie the TabPrevious wrap while the TabsNext does not.
Comment 1 Christian Persch 2013-01-07 19:32:58 UTC 
Comment on attachment 232620 [details] [review]
window: fix TabsNext/TabsNextPrevious.

This patch is obviously wrong (and doesn't fix the FIXME in the correct way). Tab next/prev not working has some other cause.
Comment 2 Christian Persch 2013-01-14 17:03:16 UTC 
Fixed the tabs next/prev keybinding on master. The FIXME would only matter if we're going to make a TerminalMdiContainer that's not a GtkNotebook.