After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691042 - UnlockDialog: honor org.gnome.desktop.screensaver.user-switch-enabled
UnlockDialog: honor org.gnome.desktop.screensaver.user-switch-enabled
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: lock-screen
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-01-03 00:03 UTC by Giovanni Campagna
Modified: 2013-01-03 00:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
UnlockDialog: honor org.gnome.desktop.screensaver.user-switch-enabled (4.28 KB, patch)
2013-01-03 00:03 UTC, Giovanni Campagna 		reviewed Details | Review
UnlockDialog: honor org.gnome.desktop.screensaver.user-switch-enabled (3.59 KB, patch)
2013-01-03 00:26 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2013-01-03 00:03:44 UTC 
The screensaver schema has a key that it is meant for locking down
the ability to switch user when the screen is locked, but support
for it was not implemented in the new screenshield.
Fix that by checking the key before creating the button.
Comment 1 Giovanni Campagna 2013-01-03 00:03:47 UTC 
Created attachment 232597 [details] [review]
UnlockDialog: honor org.gnome.desktop.screensaver.user-switch-enabled
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-01-03 00:22:00 UTC 
Review of attachment 232597 [details] [review]:

::: js/ui/unlockDialog.js
@@ +199,3 @@
                                           y_align: St.Align.MIDDLE });
 
+        let screenSaverSettings = new Gio.Settings({ schema: 'org.gnome.desktop.screensaver' });

Do we need to respect changes at runtime? I don't think we do, so OK.

::: src/shell-js.c
@@ -55,3 @@
                          &target_object))
     {
-      char *message;

completely unrelated
Comment 3 Giovanni Campagna 2013-01-03 00:25:38 UTC 
(In reply to comment #2)
> Review of attachment 232597 [details] [review]:
> 
> ::: js/ui/unlockDialog.js
> @@ +199,3 @@
>                                            y_align: St.Align.MIDDLE });
> 
> +        let screenSaverSettings = new Gio.Settings({ schema:
> 'org.gnome.desktop.screensaver' });
> 
> Do we need to respect changes at runtime? I don't think we do, so OK.

Me neither, that's why I didn't write it.

> ::: src/shell-js.c
> @@ -55,3 @@
>                           &target_object))
>      {
> -      char *message;
> 
> completely unrelated

Indeed. git commit -a bit me again!
Comment 4 Giovanni Campagna 2013-01-03 00:26:49 UTC 
Created attachment 232598 [details] [review]
UnlockDialog: honor org.gnome.desktop.screensaver.user-switch-enabled

The screensaver schema has a key that it is meant for locking down
the ability to switch user when the screen is locked, but support
for it was not implemented in the new screenshield.
Fix that by checking the key before creating the button.
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-01-03 00:40:41 UTC 
Review of attachment 232598 [details] [review]:

OK.
Comment 6 Giovanni Campagna 2013-01-03 00:44:28 UTC 
Attachment 232598 [details] pushed as 8f41c6b - UnlockDialog: honor org.gnome.desktop.screensaver.user-switch-enabled