After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690936 - [basesink] Lateness check should be done before ::prepare()
[basesink] Lateness check should be done before ::prepare()
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-01-01 09:13 UTC by Sebastian Dröge (slomo)
Modified: 2013-01-01 09:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
basesink: Check if buffers are too late before calling prepare/prepare_list (2.12 KB, patch)
2013-01-01 09:24 UTC, Sebastian Dröge (slomo)
none Details | Review
basesink: Check if buffers are too late before calling prepare/prepare_list (2.15 KB, patch)
2013-01-01 09:42 UTC, Sebastian Dröge (slomo)
committed Details | Review

Description Sebastian Dröge (slomo) 2013-01-01 09:13:53 UTC
See summary, otherwise even more time might be wasted for preparing a buffer that is not going to be rendered anyway
Comment 1 Sebastian Dröge (slomo) 2013-01-01 09:24:37 UTC
Created attachment 232443 [details] [review]
basesink: Check if buffers are too late before calling prepare/prepare_list
Comment 2 Sebastian Dröge (slomo) 2013-01-01 09:42:55 UTC
Created attachment 232445 [details] [review]
basesink: Check if buffers are too late before calling prepare/prepare_list
Comment 3 Sebastian Dröge (slomo) 2013-01-01 09:49:13 UTC
commit c859a1719ccfaa094d34d251f493f635b85fd1a9
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Tue Jan 1 10:23:59 2013 +0100

    basesink: Check if buffers are too late before calling prepare/prepare_list
    
    https://bugzilla.gnome.org/show_bug.cgi?id=690936