After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690908 - adapter: wrong return value on gst_adapter_masked_scan_*
adapter: wrong return value on gst_adapter_masked_scan_*
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Mac OS
: Normal normal
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-12-30 22:41 UTC by Thijs Vermeir
Modified: 2013-01-02 12:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
001-adapter-return-gssize-from-gst_adapter_masked_scan_-.patch (2.27 KB, patch)
2012-12-30 22:42 UTC, Thijs Vermeir 		committed Details | Review

Description Thijs Vermeir 2012-12-30 22:41:51 UTC 
these functions return -1 if the match is not found so they need to return a signed type.
Comment 1 Thijs Vermeir 2012-12-30 22:42:45 UTC 
Created attachment 232413 [details] [review]
001-adapter-return-gssize-from-gst_adapter_masked_scan_-.patch
Comment 2 Tim-Philipp Müller 2012-12-31 10:50:44 UTC 
Comment on attachment 232413 [details] [review]
001-adapter-return-gssize-from-gst_adapter_masked_scan_-.patch

True, please push. Type change should be ok in this case.
Comment 3 Thijs Vermeir 2013-01-02 09:43:23 UTC 
commit 67fab5eaa528edd705731c72c4695f9800ceda07
Author: Thijs Vermeir <thijsvermeir@gmail.com>
Date:   Sun Dec 30 23:35:48 2012 +0100

    adapter: return gssize from gst_adapter_masked_scan_* functions
    
    As the return value of this function is -1 when the match is not found