GNOME Bugzilla – Bug 690779
Boxes shouldn't let the user eject the installer ISO while an (unattended) installation is going on
Last modified: 2016-03-31 13:56:47 UTC
Start an unattended installation, go to the VM properties and then to the 'devices' section. There's a 'remove' button next to the installation ISO image. I've checked that clicking on it after starting an unattended win7 install causes the installation to fail.
Created attachment 238649 [details] [review] libvirt-machine-props: Separate method for cdrom prop adding Refactor code adding CDROM property into a separate function.
Created attachment 238650 [details] [review] Don't provide option to eject CDROM during installation Both installation and live sessions require the installer/live media to be present and therefore it does not make sense to allow users to eject it during installation/live session. User could accidently click the 'Remove' button and everythig goes boom.
Created attachment 238651 [details] [review] property: API to set sensitivity of prop widgets
Created attachment 238652 [details] [review] Disallow changing of system props during install Changing of system properties require a reboot and rebooting the machine in the middle of an installation/live sesison is not a good idea. More so since we track end of installation/live session through number of reboots, epecially in case of live session where we automatically remove the machine on shutdown/reboot if no installation was performed.
Review of attachment 238652 [details] [review]: s/sesison/session/ s/epecially/especially/
Attachment 238649 [details] pushed as 46c4835 - libvirt-machine-props: Separate method for cdrom prop adding Attachment 238650 [details] pushed as 4bed1f5 - Don't provide option to eject CDROM during installation Attachment 238651 [details] pushed as 6af8b9b - property: API to set sensitivity of prop widgets Attachment 238652 [details] pushed as 59dbcc5 - Disallow changing of system props during install