GNOME Bugzilla – Bug 690594
Root authentication popup allows input after pressing enter.
Last modified: 2021-07-05 14:23:46 UTC
As summary. It's confusing that it's not visible when the dialog's started to check the password entered. Especially noticeable in combination with bug 690592, where it causes a few seconds of uncertainty whether or not the bug occurred.
I pretty sure this issue is specific to the polkit dialog and It seems that the polkit/pam calls takes a long time to complete, when an incorrect password is entered. Possibly pam is trying to fallback through various auth modules (which itself might just be the default ubuntu config?), I saw attempted calls to winbind in my original bug 683179. Perhaps there should be some sort of progress 'spinner' on these polkit dialog.
Yes, I'm talking about the gnome 3/gnome-shell authentication dialog, not gksu or other alternatives.
Created attachment 232070 [details] [review] polkitAgent: Don't use setButtons
Created attachment 232071 [details] [review] polkitAgent: Make sure the entries are insensitive after submission It feels weird and strange to be able to type in the polkit agent dialog after hitting enter.
Created attachment 232072 [details] [review] keyring: Don't use setButtons
Created attachment 232073 [details] [review] keyring: Make sure the entries are insensitive after submission
Created attachment 232074 [details] [review] modalDialog: Make the button layout visible always With the last button-less modal dialog gone, there's no reason it should ever be hidden.
Review of attachment 232070 [details] [review]: OK.
Review of attachment 232071 [details] [review]: LG.
Review of attachment 232072 [details] [review]: OK.
Review of attachment 232073 [details] [review]: OK.
Review of attachment 232074 [details] [review]: Makes sense.
Attachment 232070 [details] pushed as 4231c87 - polkitAgent: Don't use setButtons Attachment 232071 [details] pushed as cedd68c - polkitAgent: Make sure the entries are insensitive after submission Attachment 232072 [details] pushed as ac202cb - keyring: Don't use setButtons Attachment 232073 [details] pushed as fc9225e - keyring: Make sure the entries are insensitive after submission Attachment 232074 [details] pushed as 42e58a4 - modalDialog: Make the button layout visible always This wasn't actually the bug in question -- clarification on IRC meant the dialog accepted no input and activated on key-release, so that quickly activating an app that required PK permissions from the overview meant that the dialog would get eaten up by the key release if one was quick enough. So not marking FIXED.
As clarified on IRC I filed a separate bug for that issue; this bug is purely for the lack of indication that the pkexec dialog is checking the password. If these changes fix that issue (and it looks like they should), then this bug can be marked fixed.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new ticket at https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/ Thank you for your understanding and your help.