GNOME Bugzilla – Bug 690422
Add smartcard support
Last modified: 2016-03-31 13:53:41 UTC
If --enable-smartcard support is passed we create new VMs with smartcard support, or let you add it to old VMs. This requires the new libvirt-glib smartcard support
Created attachment 231812 [details] [review] Add smartcard support
Review of attachment 231812 [details] [review]: Looks good otherwise. I assume you tested this change. I don't have a smartcard so can't test. :( ::: configure.ac @@ +49,3 @@ GTK_VNC_MIN_VERSION=0.4.4 +LIBVIRT_GLIB_MIN_VERSION=0.1.5 +LIBVIRT_GCONFIG_MIN_VERSION=0.1.5 Lets put that in a separate commit, please. Just makes it easy to not miss dep changes while writing release notes. ::: src/libvirt-machine.vala @@ +554,3 @@ var inactive_config = domain.get_config (GVir.DomainXMLFlags.INACTIVE); foreach (var device in inactive_config.get_devices ()) { + print ("%s\n", Type.from_instance (device).name()); Don't forget to remove this. :) @@ +586,3 @@ } + /* Only add usb support to guests if HAVE_SMARTCARD, as qemu built coding-style nitpick: Use //
Attachment 231812 [details] pushed as 39b39e6 - Add smartcard support