After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690364 - Fix detection of release vs development build
Fix detection of release vs development build
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-omx
unspecified
Other All
: Normal normal
: 0.10.2
Assigned To: Felipe Contreras (banned)
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-12-17 17:43 UTC by Ross Burton
Modified: 2012-12-17 22:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
common: bump to latest 0.10 revision (607 bytes, patch)
2012-12-17 17:43 UTC, Ross Burton
committed Details | Review
build: check nano version and add option to disable fatal warnings (967 bytes, patch)
2012-12-17 17:43 UTC, Ross Burton
committed Details | Review

Description Ross Burton 2012-12-17 17:43:42 UTC
gst-openmax always thinks it's doing a development build so always enables
-Werror, which is Bad.
Comment 1 Ross Burton 2012-12-17 17:43:44 UTC
Created attachment 231751 [details] [review]
common: bump to latest 0.10 revision

Signed-off-by: Ross Burton <ross.burton@intel.com>
Comment 2 Ross Burton 2012-12-17 17:43:47 UTC
Created attachment 231752 [details] [review]
build: check nano version and add option to disable fatal warnings

Signed-off-by: Ross Burton <ross.burton@intel.com>
Comment 3 Tim-Philipp Müller 2012-12-17 18:51:38 UTC
Well, that disabled -Werror by accident, because gst-openmax was using 'git describe' for git versioning...

commit 1bf085ae714e5cfc3ec1f65ef9b6e489a85c54d9
Author: Tim-Philipp Müller <tim@centricular.net>
Date:   Mon Dec 17 18:44:42 2012 +0000

    build: do gst-style git versioning, so AS_NANO works properly
    
    https://bugzilla.gnome.org/show_bug.cgi?id=690364

commit ac46931f299c06b75e052431eccb1f1b725183c3
Author: Ross Burton <ross.burton@intel.com>
Date:   Mon Dec 17 17:35:59 2012 +0000

    build: check nano version and add option to disable fatal warnings
    
    Signed-off-by: Ross Burton <ross.burton@intel.com>
    
    https://bugzilla.gnome.org/show_bug.cgi?id=690364

commit 6a4ffbc0b9be2d371c4ced0b3666227dc363911f
Author: Ross Burton <ross.burton@intel.com>
Date:   Mon Dec 17 17:35:08 2012 +0000

    common: bump to latest 0.10 revision
    
    Signed-off-by: Ross Burton <ross.burton@intel.com>
    
    https://bugzilla.gnome.org/show_bug.cgi?id=690364
Comment 4 Ross Burton 2012-12-17 22:40:33 UTC
Ah, I saw it had git tags of the form v0.10.0.3 and some sed magic, presumed it worked.  Thanks for merging.