After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690180 - panel: Update corners' nearest button on session mode change
panel: Update corners' nearest button on session mode change
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-12-13 21:49 UTC by Rui Matos
Modified: 2013-01-04 13:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
panel: Remove unused method (1.08 KB, patch)
2012-12-13 21:49 UTC, Rui Matos 		committed Details | Review
panel: Update corners' nearest button on session mode change (3.99 KB, patch)
2012-12-13 21:49 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2012-12-13 21:49:39 UTC 
The panel corners don't light up in the overview until one of the
panel buttons is clicked. That's because we are getting a
style-changed signal for the panel boxes when first showing the panel
but by then the session mode hasn't been updated yet so the boxes are
empty and thus we are not able to determine a button with which to
sync the corners' style.
Comment 1 Rui Matos 2012-12-13 21:49:42 UTC 
Created attachment 231514 [details] [review]
panel: Remove unused method
Comment 2 Rui Matos 2012-12-13 21:49:45 UTC 
Created attachment 231515 [details] [review]
panel: Update corners' nearest button on session mode change

With panel buttons changing dynamically on session mode changes we can
no longer rely on a corner's respective box style-changed signal to
find the nearest button.

Instead, make the panel take care of telling the corners to look for a
new button when buttons are changed.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-01-04 13:14:38 UTC 
Review of attachment 231514 [details] [review]:

Heh, this method literally does nothing. Good catch.
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-01-04 13:23:35 UTC 
Review of attachment 231515 [details] [review]:

OK.
Comment 5 Rui Matos 2013-01-04 13:42:15 UTC 
Attachment 231514 [details] pushed as 906ec3c - panel: Remove unused method
Attachment 231515 [details] pushed as d87db04 - panel: Update corners' nearest button on session mode change