GNOME Bugzilla – Bug 690175
Refactor WorkspaceThumbnail to be independent from WorkspacesDisplay
Last modified: 2012-12-19 10:55:17 UTC
The final goal is to decouple completely WorkspaceThumbnail from WorkspacesDisplay, and add it directly to the overview's box layout; these are a few preparatory patches that will help us getting there.
Created attachment 231504 [details] [review] workspaceThumbnail: make ThumbnailsBox track workspace changes itself Instead of having WorkspacesDisplay calling us. https://bugzilla.gnome.org/show_bug.cgi?id=682050
Created attachment 231505 [details] [review] workspaceThumbnail: handle scroll-event internally Instead of having WorkspacesDisplay calling us. https://bugzilla.gnome.org/show_bug.cgi?id=682050
Created attachment 231506 [details] [review] workspaceThumbnail: handle entering the overview internally Instead of having WorkspacesDisplay calling us.
Created attachment 231507 [details] [review] workspaceThumbnail: unify restack handling Both WorkspacesDisplay and ThumbnailsBox need to know when windows have been restacked. Instead of each tracking changes on their own or trying to call each other, have the overview keep track and do the calculations, emitting a signal with the result.
Review of attachment 231504 [details] [review]: OK.
Review of attachment 231505 [details] [review]: OK.
Review of attachment 231506 [details] [review]: Commit message needs work. Try something like: workspaceThumbnail: handle showing/hiding when entering/hiding the overview ourselves Instead of having WorkspacesDisplay show/hide us.
Review of attachment 231507 [details] [review]: ::: js/ui/overview.js @@ +395,3 @@ + } + + this.emit('sync-window-stacking', stackIndices); 'windows-restacked' or something. It should be the past tense of a verb if we're not talking about a vfunc signal where we can *change* the synchronization of the window stacking.
Created attachment 231711 [details] [review] workspaceThumbnail: unify restack handling -- Use a better name for the signal
Review of attachment 231711 [details] [review]: OK.
Pushed, thanks.