After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690173 - extensionSystem: Fix error reporting in Looking Glass / ListExtensionErrors()
extensionSystem: Fix error reporting in Looking Glass / ListExtensionErrors()
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-12-13 18:49 UTC by Florian Müllner
Modified: 2012-12-13 19:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
extensionSystem: Fix error reporting in lg / ListExtensionErrors() (1013 bytes, patch)
2012-12-13 18:49 UTC, Florian Müllner 		committed Details | Review
extensionUtils: Remove unused property (818 bytes, patch)
2012-12-13 18:49 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2012-12-13 18:49:43 UTC 
See patches.
Comment 1 Florian Müllner 2012-12-13 18:49:45 UTC 
Created attachment 231500 [details] [review]
extensionSystem: Fix error reporting in lg / ListExtensionErrors()

Commit c99e8eb29 removed this line probably accidentally, as no
effort has been made to replace consumers in lookingGlass and
shellDBus.
Comment 2 Florian Müllner 2012-12-13 18:49:49 UTC 
Created attachment 231501 [details] [review]
extensionUtils: Remove unused property
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-12-13 18:52:34 UTC 
Review of attachment 231500 [details] [review]:

This was indeed accidental. Good spot.
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-12-13 18:52:50 UTC 
Review of attachment 231501 [details] [review]:

OK.
Comment 5 Florian Müllner 2012-12-13 18:56:11 UTC 
Attachment 231500 [details] pushed as 378df51 - extensionSystem: Fix error reporting in lg / ListExtensionErrors()
Attachment 231501 [details] pushed as 28aa920 - extensionUtils: Remove unused property
Comment 6 Jasper St. Pierre (not reading bugmail) 2012-12-13 19:17:35 UTC 
No, the "removed unused property" one is wrong. Reverted.
Comment 7 Florian Müllner 2012-12-13 19:20:39 UTC 
Yeah, I was about to revert that as well.