After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690058 - Install a search provider
Install a search provider
Status: RESOLVED OBSOLETE
Product: yelp
Classification: Applications
Component: Search
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Yelp maintainers
Yelp maintainers
Depends on:
Blocks:
 
 
Reported: 2012-12-11 17:38 UTC by Petr Kovar
Modified: 2018-05-22 13:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
libyelp: keep passed-in URI alive while resolving parent (1.72 KB, patch)
2018-04-10 04:41 UTC, Cosimo Cecchi
none Details | Review
src: handle --gapplication-service flag (1.19 KB, patch)
2018-04-10 04:41 UTC, Cosimo Cecchi
none Details | Review
yelp-uri: export default uri as YELP_GNOME_HELP_URI (2.04 KB, patch)
2018-04-10 04:41 UTC, Cosimo Cecchi
none Details | Review
Make application D-Bus launchable (5.97 KB, patch)
2018-04-10 04:41 UTC, Cosimo Cecchi
none Details | Review
src: add actions to yelp (2.46 KB, patch)
2018-04-10 04:41 UTC, Cosimo Cecchi
none Details | Review
search-provider: add search provider (26.98 KB, patch)
2018-04-10 04:41 UTC, Cosimo Cecchi
none Details | Review

Description Petr Kovar 2012-12-11 17:38:04 UTC
Install a search provider to index locally installed documentation (eg. Mallard & DocBook XML documents, HTML files) to allow users to search for user documentation from a single place.

Downstream distributors and ISVs often distribute documents (Mallard & DocBook XML documents, HTML and PDF files) and install them into a common system-wide documentation directory (normally /usr/share/doc/).

Currently, users can't easily access these documents via Yelp / Shell search without digging many levels deep into the file system.

Somewhat related bug: #652057
Comment 1 Shaun McCance 2012-12-11 20:51:10 UTC
Do you want links to all matching topics in all help documents to show up in the shell? That's how search worked in Yelp 2. It wasn't very useful.

Also, I'm not touching /usr/share/doc/. It's a grab bag of assorted files with no specification on what's where. If you want your document in Yelp, use /usr/share/help/.
Comment 2 Petr Kovar 2013-01-18 17:23:09 UTC
Some relevant background information: https://live.gnome.org/Design/Apps/Help
Comment 3 Marcus Lundblad 2014-08-05 09:04:18 UTC
I think it would be quite useful to be able search for Unix man pages via the search provider.
Comment 4 Cosimo Cecchi 2018-04-10 02:39:33 UTC
FWIW we implemented this in Endless. I will try to upload a patchset here.
Comment 5 Cosimo Cecchi 2018-04-10 02:39:51 UTC
(Endless code at https://github.com/endlessm/yelp/commits/master)
Comment 6 Cosimo Cecchi 2018-04-10 04:41:08 UTC
Created attachment 370716 [details] [review]
libyelp: keep passed-in URI alive while resolving parent

The caller may release the last reference to the uri it passes in.
Comment 7 Cosimo Cecchi 2018-04-10 04:41:13 UTC
Created attachment 370717 [details] [review]
src: handle --gapplication-service flag

When we launch the application from D-Bus, we just pass in the
--gapplication-service flag, where as yelp expects a file to be passed
in as an argument.
Make sure to only take the file codepath when a file is passed.
Comment 8 Cosimo Cecchi 2018-04-10 04:41:18 UTC
Created attachment 370718 [details] [review]
yelp-uri: export default uri as YELP_GNOME_HELP_URI

To avoid duplication, we export the default uri so it can be used
across the project.
Comment 9 Cosimo Cecchi 2018-04-10 04:41:27 UTC
Created attachment 370719 [details] [review]
Make application D-Bus launchable

Changing the application to be launchable from D-Bus,
we needed to rename desktop file according to yelp application ID.
Also add the yelp service file and add --gapplication-service flag to it.
Comment 10 Cosimo Cecchi 2018-04-10 04:41:35 UTC
Created attachment 370720 [details] [review]
src: add actions to yelp

To be able to launch yelp via the search provider launch_search and
activate_result functions, adjustments had to be made to yelp application.

"show-page" action is used to display specific page.
"show-search" action to display search page with results for given term.
Comment 11 Cosimo Cecchi 2018-04-10 04:41:43 UTC
Created attachment 370721 [details] [review]
search-provider: add search provider
Comment 12 GNOME Infrastructure Team 2018-05-22 13:00:08 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/yelp/issues/72.