After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690031 - d3dvideosink makefile missing GST_PLUGINS_BASE_CFLAGS and GMODULE_NO_EXPORT_LIBS
d3dvideosink makefile missing GST_PLUGINS_BASE_CFLAGS and GMODULE_NO_EXPORT_LIBS
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Windows
: Normal normal
: 1.0.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-12-11 07:39 UTC by Michael Esemplare
Modified: 2012-12-11 21:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
d3dvideosink makefile patch (900 bytes, patch)
2012-12-11 17:53 UTC, Michael Esemplare
committed Details | Review

Description Michael Esemplare 2012-12-11 07:39:27 UTC
I am building gstreamer with jenkins and each product (core, base, bad, etc..)
are built in their own directories. This build exposed some missing linkages.

Errors:

make[3]: Entering directory `/var/lib/jenkins/jobs/gst-plugins-bad/workspace/host_target/win32/sys/d3dvideosink'
  CC     libgstd3dvideosink_la-d3dvideosink.lo
In file included from d3dvideosink.c:25:0:
d3dvideosink.h:24:29: fatal error: gst/video/video.h: No such file or directory
compilation terminated.

Creating library file: .libs/libgstd3dvideosink.dll.a.libs/libgstd3dvideosink_la-dx.o: In function `directx_determine_best_available_api':
/var/lib/jenkins/jobs/gst-plugins-bad/workspace/host_target/win32/sys/d3dvideosink/directx/dx.c:242: undefined reference to `_g_module_supported'
/var/lib/jenkins/jobs/gst-plugins-bad/workspace/host_target/win32/sys/d3dvideosink/directx/dx.c:263: undefined reference to `_g_module_open_utf8'
/var/lib/jenkins/jobs/gst-plugins-bad/workspace/host_target/win32/sys/d3dvideosink/directx/dx.c:268: undefined reference to `_g_module_symbol'
/var/lib/jenkins/jobs/gst-plugins-bad/workspace/host_target/win32/sys/d3dvideosink/directx/dx.c:274: undefined reference to `_g_module_close'
/var/lib/jenkins/jobs/gst-plugins-bad/workspace/host_target/win32/sys/d3dvideosink/directx/dx.c:269: undefined reference to `_g_module_close'
.libs/libgstd3dvideosink_la-dx9_d3d.o: In function `dx9_d3d_init':
/var/lib/jenkins/jobs/gst-plugins-bad/workspace/host_target/win32/sys/d3dvideosink/directx/directx9/dx9_d3d.c:48: undefined reference to `_g_module_symbol'
/var/lib/jenkins/jobs/gst-plugins-bad/workspace/host_target/win32/sys/d3dvideosink/directx/directx9/dx9_d3d.c:45: undefined reference to `_g_module_open_utf8'
.libs/libgstd3dvideosink_la-dx10_d3d.o: In function `dx10_d3d_init':
/var/lib/jenkins/jobs/gst-plugins-bad/workspace/host_target/win32/sys/d3dvideosink/directx/directx10/dx10_d3d.c:36: undefined reference to `_g_module_symbol'
/var/lib/jenkins/jobs/gst-plugins-bad/workspace/host_target/win32/sys/d3dvideosink/directx/directx10/dx10_d3d.c:32: undefined reference to `_g_module_open_utf8'
.libs/libgstd3dvideosink_la-dx11_d3d.o: In function `dx11_d3d_init':
/var/lib/jenkins/jobs/gst-plugins-bad/workspace/host_target/win32/sys/d3dvideosink/directx/directx11/dx11_d3d.c:31: undefined reference to `_g_module_open_utf8'
collect2: ld returned 1 exit status


I have attached a patch to fix the errors.
Comment 1 Sebastian Dröge (slomo) 2012-12-11 11:01:05 UTC
You forgot to attach the patch. Please do so :)
Comment 2 Michael Esemplare 2012-12-11 17:53:29 UTC
Created attachment 231295 [details] [review]
d3dvideosink makefile patch
Comment 3 Michael Esemplare 2012-12-11 17:54:42 UTC
Right, I knew it was missing something :)
Comment 4 Tim-Philipp Müller 2012-12-11 21:03:49 UTC
Thanks! A 'git format-patch -1' style patch would be appreciated next time, so it already includes the author and commit mesage :)


commit 09512c5db11e7bd4490ac4e4cfeb8ccf0d1d2c57
Author: Michael Esemplare <michael.esemplare@gmail.com>
Date:   Tue Dec 11 20:58:42 2012 +0000

    d3dvideosink: fix compiler and linker flags
    
    https://bugzilla.gnome.org/show_bug.cgi?id=690031