GNOME Bugzilla – Bug 689981
avviddec: 0.9 port - opaque pointer sometimes NULL - causing crashes - make check fails
Last modified: 2012-12-11 10:52:10 UTC
'make check' exposes this problem, but I also run into this every few times with a simple gst-launch-1.0 playbin pipeline (h264-in-matroska):
+ Trace 231278
Thread 4 (Thread 0x7f4d1297e700 (LWP 18084))
commit 06de84c7477e9c917d44ff793aecd65e3a3226f5 Author: Sebastian Dröge <sebastian.droege@collabora.co.uk> Date: Tue Dec 11 10:34:42 2012 +0000 avviddec: Fix memory leak if we already allocated an output buffer for the frame commit 76b8b8c67f7c8fdf03d8d7d5c98b1e5fb83f50e0 Author: Wim Taymans <wim.taymans@collabora.co.uk> Date: Tue Dec 11 10:22:34 2012 +0100 Revert "avviddec: Fix memory leaks and assertions in error cases if we can't allocate a frame" This reverts commit 47647e1caca117ff8a62caf8bf0b6c94eb6dd025. Breaks playback when direct rendering is disabled. The reason is that we set the opaque vaue to NULL and then try to use the NULL value when we decoded a frame.