GNOME Bugzilla – Bug 689952
Add introspection support for Windows MSVC builds
Last modified: 2013-02-20 10:51:37 UTC
Created attachment 231113 [details] [review] Update atk.symbols for the missed symbols Hi, I have come up with some patches to enable the build of introspection support on Windows, without the need of a bash-style shell. First up, is to update atk.symbols to make up for the items that need to be exported so that the dumper program can be properly linked.
Created attachment 231114 [details] [review] Batch to build the introspection files for ATK Next is the Windows batch (.bat) file to build and "install" the Atk-1.0.gir and Atk-1.0.typelib introspection files with an MSVC build of ATK, which does not require the use of a MSYS/Cygwin/BASH style shell on Windows. A file list needs to be created for this to work, so I will work on this and post the updates to the autotools files for this part in the next few days. With blessings, thank you!
Review of attachment 231113 [details] [review]: Looks good to me
Review of attachment 231114 [details] [review]: Well, I don't have any experience with Windows MSVC builds and I don't have any way to test it. Anyway, What I see seems to make sense, you are really experienced with this and this will not affect the most common GNOME platform (Linux) so I'm ok with this. If you think that it is ok, go on with the change.
Review of attachment 231113 [details] [review]: Pushed as 5235e68e. Sorry I forgot to include the bug number in the commit :|
Review of attachment 231114 [details] [review]: Pushed as 59d01864. Sorry I forgot to include the bug number in the commit message for this as well :| With blessings, thank you!
(In reply to comment #5) > Review of attachment 231114 [details] [review]: > > Pushed as 59d01864. Sorry I forgot to include the bug number in the commit > message for this as well :| > > With blessings, thank you! Taking into account that the patches were pushed I'm closing the bug. Those commits will be included on the 2.7.3 release. Thanks.
Created attachment 233740 [details] [review] Create a filelist to create the ATK .gir/.typelib files on Windows Hi, Sorry, this patch came much later than I would have liked. This adds an autotools file which is included by atk/Makefile.am to create the atk_list filelist file to be consumed by the gengir.bat, in order to generate the .gir/.typelib files for ATK for Visual C++ builds. This also dists the gengir.bat and the generated atk_list in the tarballs. With blessings, thank you!
Hi, Bug is superseded by https://bugzilla.gnome.org/show_bug.cgi?id=694255. Thank you, with blessings!