After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689749 - Fix asynchronous file loading
Fix asynchronous file loading
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 689760 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-12-06 00:32 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-12-06 18:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fileUtils: Make sure we properly keep track of how many dirs to load (970 bytes, patch)
2012-12-06 00:32 UTC, Jasper St. Pierre (not reading bugmail) 		none Details | Review
fileUtils: Make sure to go to the next dir if we get an error (1.85 KB, patch)
2012-12-06 00:32 UTC, Jasper St. Pierre (not reading bugmail) 		none Details | Review
fileUtils: Make sure we properly keep track of how many dirs to load (1.37 KB, patch)
2012-12-06 16:01 UTC, Jasper St. Pierre (not reading bugmail) 		none Details | Review
fileUtils: Don't fail if we can't find an error (2.28 KB, patch)
2012-12-06 17:02 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-12-06 00:32:36 UTC 
This recently broke my shell. See patches.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-12-06 00:32:38 UTC 
Created attachment 230859 [details] [review]
fileUtils: Make sure we properly keep track of how many dirs to load

Otherwise we'll complete loading too early, after the first dir has
loaded.
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-12-06 00:32:41 UTC 
Created attachment 230860 [details] [review]
fileUtils: Make sure to go to the next dir if we get an error

Otherwise, non-existant dirs will keep files from being loaded.
Comment 3 Allison Karlitskaya (desrt) 2012-12-06 07:39:04 UTC 
*** Bug 689760 has been marked as a duplicate of this bug. ***
Comment 4 Debarshi Ray 2012-12-06 12:24:09 UTC 
While they fix it for cases where $datadir/gnome-shell/modes is absent, they break it for cases where it is present.
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-12-06 16:01:15 UTC 
Created attachment 230899 [details] [review]
fileUtils: Make sure we properly keep track of how many dirs to load

Otherwise there could be a race here, where we'll either stop loading
after the first dir has loaded, or we'll not finish if we have an error.
Comment 6 Florian Müllner 2012-12-06 16:19:28 UTC 
The 2nd patch fixes a problem introduced in the 1st one, so please squash them.
Comment 7 Jasper St. Pierre (not reading bugmail) 2012-12-06 17:02:23 UTC 
Created attachment 230903 [details] [review]
fileUtils: Don't fail if we can't find an error

We need to make sure that we decrement the number of dirs that
we've loaded, and call the callback on error.
Comment 8 Cosimo Cecchi 2012-12-06 17:26:54 UTC 
Review of attachment 230903 [details] [review]:

Looks good to me
Comment 9 Jasper St. Pierre (not reading bugmail) 2012-12-06 18:37:01 UTC 
Attachment 230903 [details] pushed as ed12c9d - fileUtils: Don't fail if we can't find an error