GNOME Bugzilla – Bug 689653
Add a "Windows" option to Ctrl+Alt+Tab
Last modified: 2012-12-07 18:09:35 UTC
When Rui "fixed" the Ctrl+Alt+Tab switcher to select the second item by default, I knew I had to add this.
Created attachment 230690 [details] [review] switcherPopup: Add a timestamp argument to _finish() And use it elsewhere.
Created attachment 230691 [details] [review] ctrlAltTab: Remove some dead code for a "window" parameter This isn't set on any item, so we can safely remove it.
Created attachment 230692 [details] [review] ctrlAltTab: Only add to the focus manager if we have an StWidget.
Created attachment 230693 [details] [review] ctrlAltTab: Add a "Windows" option to Ctrl+Alt+Tab This lets accessibility users easily access the desktop after focusing the panel.
Created attachment 230694 [details] [review] grabHelper: Use focus_default_window This prevents us from having to track the previously focused window.
Review of attachment 230690 [details] [review]: The _finish() call in SwitcherPopup._itemActivated() and _finish() itself should take the parameter as well. ::: js/ui/altTab.js @@ +240,1 @@ this.parent(); this should take the parameter for consistency
Review of attachment 230691 [details] [review]: ++
Review of attachment 230692 [details] [review]: Ok with that extraneous line remove. ::: js/ui/ctrlAltTab.js @@ +49,3 @@ for (let i = 0; i < this._items.length; i++) { if (this._items[i].root == root) { + let item = this._items[i]; leftover?
Review of attachment 230693 [details] [review]: Fine.
Review of attachment 230694 [details] [review]: Ok
Created attachment 230855 [details] [review] switcherPopup: Add a timestamp argument to _finish() And use it elsewhere.
Review of attachment 230855 [details] [review]: Ok
Attachment 230691 [details] pushed as 1f46a0d - ctrlAltTab: Remove some dead code for a "window" parameter Attachment 230692 [details] pushed as 4728105 - ctrlAltTab: Only add to the focus manager if we have an StWidget. Attachment 230693 [details] pushed as 349c642 - ctrlAltTab: Add a "Windows" option to Ctrl+Alt+Tab Attachment 230694 [details] pushed as 4153fee - grabHelper: Use focus_default_window Attachment 230855 [details] pushed as 7ff7ced - switcherPopup: Add a timestamp argument to _finish()
(In reply to comment #8) > ::: js/ui/ctrlAltTab.js > @@ +49,3 @@ > for (let i = 0; i < this._items.length; i++) { > if (this._items[i].root == root) { > + let item = this._items[i]; > > leftover? This got pushed.
Worse, focus_default_window() got pushed, but the method is on MetaWorkspace, not MetaScreen
(In reply to comment #15) > Worse, focus_default_window() got pushed, but the method is on MetaWorkspace, > not MetaScreen See https://bugzilla.gnome.org/show_bug.cgi?id=689652, which is in deps. I forgot to push it.
(In reply to comment #14) > (In reply to comment #8) > > ::: js/ui/ctrlAltTab.js > > @@ +49,3 @@ > > for (let i = 0; i < this._items.length; i++) { > > if (this._items[i].root == root) { > > + let item = this._items[i]; > > > > leftover? > > This got pushed. Pushed a small cleanup.