GNOME Bugzilla – Bug 689607
privacy panel ux review
Last modified: 2013-02-13 14:31:59 UTC
Created attachment 230641 [details] screenshots Based on master at 0a7d184df49bb6ccd. Panel * Rows should not get selected, and the first item should not be selected by default * Rows should have a hover effect and a pressed state * Rows should be taller * List should encapsulate the visible rows - there should not be empty space below them Dialogs - recurrent issues * Too much space between window title and description text * "Done" looks a bit odd with the buttons in the current position. "Close" might be better Screen Lock * Control labels are not aligned with description text above * Control widgets should be right aligned Name & Visibily * Control labels are not aligned with description text above * Control widgets should be right aligned * Stealth mode should be capitalised * It is unclear what stealth mode means Usage & History * How can "Usage & History" be "On"? * Done button is too wide, and doesn't have a strong relationship with Clear Recent History. Maybe make them different widths, and left-align Clear Recent History Purge Trash & Temporary Files * Again, "On" and "Off" doesn't make a lot of sense here * Inconsistent padding between buttons * Would be better to left-align Empty Trash and Purge Temporary Files
Created attachment 230720 [details] [review] privacy: turn off selection No selection needed here.
Created attachment 230721 [details] [review] privacy: Make rows a little bigger This was requested in design review.
Created attachment 230722 [details] [review] privacy: fix list sizing issues Make the list not expand all the way to the bottom.
Created attachment 230723 [details] [review] privacy: Fix alignment issues in the screen lock dialog Pointed out in review.
Created attachment 230724 [details] [review] privacy: Fix alignment issues in the name dialog These were pointed out in review.
Created attachment 230725 [details] [review] privacy: Fix alignment issues in recent dialog These were pointed out in review.
Created attachment 230726 [details] [review] privacy: Fix alignment issues in the trash dialog These were pointed out in review.
Attachment 230721 [details] pushed as a332cc8 - privacy: Make rows a little bigger Attachment 230723 [details] pushed as f935ed7 - privacy: Fix alignment issues in the screen lock dialog Attachment 230724 [details] pushed as 7cc203a - privacy: Fix alignment issues in the name dialog Attachment 230725 [details] pushed as b407467 - privacy: Fix alignment issues in recent dialog Attachment 230726 [details] pushed as 8d8fc99 - privacy: Fix alignment issues in the trash dialog
(In reply to comment #0) > Created an attachment (id=230641) [details] > screenshots > > Based on master at 0a7d184df49bb6ccd. > > Panel > > * Rows should not get selected, and the first item should not be selected by > default Fixed. > * Rows should have a hover effect and a pressed state Theming issue. > * Rows should be taller Fixed. > * List should encapsulate the visible rows - there should not be empty space > below them Fixed, and mentioned that it's a work-around for bug 689714. > Dialogs - recurrent issues > > * Too much space between window title and description text > * "Done" looks a bit odd with the buttons in the current position. "Close" > might be better Both done. > Screen Lock > > * Control labels are not aligned with description text above > * Control widgets should be right aligned Both done. > Name & Visibily > > * Control labels are not aligned with description text above > * Control widgets should be right aligned > * Stealth mode should be capitalised All done. > * It is unclear what stealth mode means It's what you put in the UI guidelines. https://live.gnome.org/Design/SystemSettings/Privacy#Tentative_Guidelines I've called the setting "Hide Identity" in the GSettings schemas. > Usage & History > > * How can "Usage & History" be "On"? Ditto (as designed). > * Done button is too wide, and doesn't have a strong relationship with Clear > Recent History. Maybe make them different widths, and left-align Clear Recent > History Done. > Purge Trash & Temporary Files > > * Again, "On" and "Off" doesn't make a lot of sense here As designed. > * Inconsistent padding between buttons Done. > * Would be better to left-align Empty Trash and Purge Temporary Files Done. A couple of comments of my own: I would have had "Purge Now" and "Empty Now" buttons. It's also not clear what "Purge After" is supposed to be attached to (the temporary files? the trash emptying?). What does "Purge After: Immediately" do?
Could the rows be taller still? They're currently 60px tall in the power panel; it would be good to be consistent. Outstanding design questions: > * It is unclear what stealth mode means I'm not entirely sure what stealth mode means, so I'm not the best person to answer that question. > * How can "Usage & History" be "On"? Perhaps we can use more elaborate status strings here. eg. "Recording usage and history", "Recording history", "Recording usage", "Not recording". A question here though: are "recently used" and "history" different things? The history combobox becomes insensitive when recently used is off: so what does "don't retain history" do? > * How can "Purge Trash & Temporary Files" be "On" and "Off"? This one might not be so bad. "Off" seems OK. I think I would have liked to have distinguished between trash and temporary file purge being on, but it is hard to do that without being verbose. Additional questions from comment 9: > I would have had "Purge Now" and "Empty Now" buttons. I personally didn't have any difficulty understanding "Empty Trash" and "Purge Temporary Files". Appending "Now" to the end of those button labels could make it clearer though. > It's also not clear what "Purge After" is supposed to be attached to (the temporary files? the trash emptying?). It is connected to the two switches above: it sets the time period after which trash and temporary files are purged. As such, the Purge After label and combobox should be insensitive when the two switches are set to off. > What does "Purge After: Immediately" do? I assume that it essentially means "never keep trash or temporary files".
(In reply to comment #10) > Could the rows be taller still? They're currently 60px tall in the power panel; we don't give the rows in the power panel a fixed height - the 60px is just what font size + 12 pixel padding works out to. But sure, we can try to match that. > > * How can "Usage & History" be "On"? > > Perhaps we can use more elaborate status strings here. eg. "Recording usage and > history", "Recording history", "Recording usage", "Not recording". > > A question here though: are "recently used" and "history" different things? The > history combobox becomes insensitive when recently used is off: so what does > "don't retain history" do? Currently, the panel only affects recent files - both controls are about that. There are other places in the desktop where history is recorded, though: - browser history - server urls in nautilus etc. Do we expect applications to pick this setting up and react accordingly ? At least core apps like web and files ? A few more things that should perhaps go in the trash/temp files part: - generic 'cache' in ~/.cache - do we want to purge that too ? - gvfs metadata has been mentioned as something that might be purged as well, but I'm not sure sure. This is things like custom icons, thumbnails, notes that are associated with files. > > What does "Purge After: Immediately" do? > > I assume that it essentially means "never keep trash or temporary files". To be clear: I just made up the contents of all the combo boxes. These should be reviewed, and cut down to a reasonable set of choices.
I made the rows taller, and added a bit more horizontal padding
(In reply to comment #11) > > > * How can "Usage & History" be "On"? ... > > A question here though: are "recently used" and "history" different things? The > > history combobox becomes insensitive when recently used is off: so what does > > "don't retain history" do? Yeah, not sure. It might be best to remove "don't retain history" - filed as bug 693710. > Currently, the panel only affects recent files - both controls are about that. > There are other places in the desktop where history is recorded, though: > - browser history > - server urls in nautilus > etc. > > Do we expect applications to pick this setting up and react accordingly ? > At least core apps like web and files ? That seems to be the implication. I've filed bug 693705 (Nautilus), bug 693707 (Web) and bug 693709 (file chooser). > A few more things that should perhaps go in the trash/temp files part: > > - generic 'cache' in ~/.cache - do we want to purge that too ? I don't know the technical details for this, but it sounds like we might - filed as bug 693711. Let's close this for now and follow up in individual bug reports.