After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689584 - Add summary and description to "show-hidden" key
Add summary and description to "show-hidden" key
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
Federico Mena Quintero
Depends on: 587806
Blocks:
 
 
Reported: 2012-12-04 00:26 UTC by Timothy Arceri
Modified: 2012-12-07 19:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch: Add summary and decription to key (1013 bytes, patch)
2012-12-04 00:26 UTC, Timothy Arceri 		none Details | Review
Fix build by un-translating org.gtk.Settings.FileChooser (1.50 KB, patch)
2012-12-07 19:07 UTC, Colin Walters 		committed Details | Review

Description Timothy Arceri 2012-12-04 00:26:40 UTC 
Created attachment 230609 [details] [review]
Patch: Add summary and decription to key

Since we want to share this key between file chooser and Nautilus (see bug #143599). This key should have a proper summary and description so that its clearer in tools such as dconf-editor what the key is used for.

Note: The description is dependent on the patch for bug #587806 being accepted.
Comment 1 Federico Mena Quintero 2012-12-07 18:01:21 UTC 
Keep up the awesome!  Pushed to master as f1532993eb5.
Comment 2 Colin Walters 2012-12-07 19:07:40 UTC 
Created attachment 230991 [details] [review]
Fix build by un-translating org.gtk.Settings.FileChooser

At the moment, gtk+ doesn't depend on intltool, which is the program
that knows how to translate schemas.  Attempting to translate them
causes a build failure, so for now, let's leave them in en_US.
Comment 3 Colin Walters 2012-12-07 19:08:04 UTC 
This patch broke the build:

http://ostree.gnome.org/work/tasks/gnomeos-3.8-build/2012.2192/log
Comment 4 Matthias Clasen 2012-12-07 19:13:27 UTC 
Review of attachment 230991 [details] [review]:

looks good
Comment 5 Colin Walters 2012-12-07 19:14:59 UTC 
Attachment 230991 [details] pushed as 549a0af - Fix build by un-translating org.gtk.Settings.FileChooser