After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689496 - Fixes for Coverity
Fixes for Coverity
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2012-12-02 19:50 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-12-03 01:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
cally-util: Don't free a NULL pointer (1010 bytes, patch)
2012-12-02 19:50 UTC, Jasper St. Pierre (not reading bugmail) 		accepted-commit_now Details | Review
grid-layout: Don't use uninitialized values (1.42 KB, patch)
2012-12-02 19:50 UTC, Jasper St. Pierre (not reading bugmail) 		accepted-commit_now Details | Review
Fix some missing va_ends (2.48 KB, patch)
2012-12-02 19:50 UTC, Jasper St. Pierre (not reading bugmail) 		accepted-commit_now Details | Review
text: Fix font fallback (779 bytes, patch)
2012-12-02 19:51 UTC, Jasper St. Pierre (not reading bugmail) 		accepted-commit_now Details | Review
gdk: Fix realization in the foreign-window case (984 bytes, patch)
2012-12-02 19:51 UTC, Jasper St. Pierre (not reading bugmail) 		accepted-commit_now Details | Review
A bunch of fixes for Coverity (4.58 KB, patch)
2012-12-02 19:51 UTC, Jasper St. Pierre (not reading bugmail) 		accepted-commit_now Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-12-02 19:50:52 UTC 
A bunch of code fixes found by Coverity, with no common
denominator.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-12-02 19:50:55 UTC 
Created attachment 230463 [details] [review]
cally-util: Don't free a NULL pointer

The only place key_event can not be NULL is in this branch.
Spotted by Coverity.
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-12-02 19:50:57 UTC 
Created attachment 230464 [details] [review]
grid-layout: Don't use uninitialized values

The clutter_actor_box_set_* methods rely on the current box
geometry, so we can't use those for an uninitialize actor box.
Found by Coverity.
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-12-02 19:50:59 UTC 
Created attachment 230465 [details] [review]
Fix some missing va_ends

Found by Coverity.
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-12-02 19:51:01 UTC 
Created attachment 230466 [details] [review]
text: Fix font fallback

Spotted by Coverity.
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-12-02 19:51:03 UTC 
Created attachment 230467 [details] [review]
gdk: Fix realization in the foreign-window case

Found by Coverity.
Comment 6 Jasper St. Pierre (not reading bugmail) 2012-12-02 19:51:06 UTC 
Created attachment 230468 [details] [review]
A bunch of fixes for Coverity

None of these are relevant enough for their own fixes.
Comment 7 Emmanuele Bassi (:ebassi) 2012-12-03 00:07:21 UTC 
Review of attachment 230464 [details] [review]:

looks good.
Comment 8 Emmanuele Bassi (:ebassi) 2012-12-03 00:08:03 UTC 
Review of attachment 230465 [details] [review]:

looks good.
Comment 9 Emmanuele Bassi (:ebassi) 2012-12-03 00:08:30 UTC 
Review of attachment 230466 [details] [review]:

looks okay
Comment 10 Emmanuele Bassi (:ebassi) 2012-12-03 00:08:59 UTC 
Review of attachment 230467 [details] [review]:

looks okay.
Comment 11 Emmanuele Bassi (:ebassi) 2012-12-03 00:09:43 UTC 
Review of attachment 230468 [details] [review]:

looks okay.
Comment 12 Emmanuele Bassi (:ebassi) 2012-12-03 00:11:08 UTC 
Review of attachment 230463 [details] [review]:

looks good. the AtkKeyEventStruct variable could be declared inside the block as well, but it's fine.
Comment 13 Jasper St. Pierre (not reading bugmail) 2012-12-03 01:19:46 UTC 
pushed all these, but Bugzilla tanked