GNOME Bugzilla – Bug 689377
Fix a compiler warning in GDBus
Last modified: 2012-12-05 18:31:11 UTC
...in two ways.
Created attachment 230339 [details] [review] gobject: Use local variable names in macros less likely to clash At least GDBus had code that had "_object" as a parameter to one of its functions, but this clashes with the GObject macro G_OBJECT_WARN_INVALID_PROPERTY_ID() which created a local "_object". Since many of us cargo cult around copies of objects, let's be defensive here and use local variable names less likely to clash with application code.
Created attachment 230340 [details] [review] gdbusobjectskeleton: Fix compiler warnings The G_OBJECT_WARN_INVALID_PROPERTY_ID() macro uses a local variable named "_object"; work around this by using "object" as the variable we pass in.
Comment on attachment 230339 [details] [review] gobject: Use local variable names in macros less likely to clash sure
Comment on attachment 230340 [details] [review] gdbusobjectskeleton: Fix compiler warnings sure, also fine
Attachment 230339 [details] pushed as 33de093 - gobject: Use local variable names in macros less likely to clash Attachment 230340 [details] pushed as 1e74e46 - gdbusobjectskeleton: Fix compiler warnings