After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689353 - St: recompute all theme nodes when the icon theme changes
St: recompute all theme nodes when the icon theme changes
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: st
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-11-30 14:52 UTC by Giovanni Campagna
Modified: 2012-12-06 22:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
St: recompute all theme nodes when the icon theme changes (2.11 KB, patch)
2012-11-30 14:52 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2012-11-30 14:52:01 UTC 
StWidget considers "same theme node" as an indication that the style
did not change, and skips emitting style-changed in that case. This
means that icon theme changes are not picked up by StIcon.
Comment 1 Giovanni Campagna 2012-11-30 14:52:04 UTC 
Created attachment 230284 [details] [review]
St: recompute all theme nodes when the icon theme changes
Comment 2 Allison Karlitskaya (desrt) 2012-12-03 01:58:51 UTC 
I am affected by this issue in two ways:

1) On login, the icons I get in my top bar are broken/ugly caused by the default
   icon theme being used before g-s-d starts and then gnome-shell not switching
   to the new theme when g-s-d is finally started.

2) When I enable/disable the high contrast icon theme, the icons are not
   updated, with the exception of the icon behind the app menu.

Both of these issues can be 'fixed' by hovering the mouse over the icon in question.

This patch fixes both issues for me.
Comment 3 Matthias Clasen 2012-12-03 04:51:41 UTC 
Yeah, I've seen that as well
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-12-03 04:54:30 UTC 
Review of attachment 230284 [details] [review]:

Sure.
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-12-06 22:43:34 UTC 
Attachment 230284 [details] pushed as 2081216 - St: recompute all theme nodes when the icon theme changes