After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689274 - gnutls: Avoid assertion in finish_handshake()
gnutls: Avoid assertion in finish_handshake()
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: network
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2012-11-29 13:16 UTC by Stef Walter
Modified: 2012-11-29 21:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gnutls: Avoid assertion in finish_handshake() (1.24 KB, patch)
2012-11-29 13:16 UTC, Stef Walter 		none Details | Review
gnutls: Avoid assertion in finish_handshake() (1.41 KB, patch)
2012-11-29 13:19 UTC, Stef Walter 		committed Details | Review

Description Stef Walter 2012-11-29 13:16:40 UTC 
It's possible (although hard to reproduce) to hit this assertion 

  g_assert (error != NULL);

in finish_handshake(). One caller of finish_handshake() doesn't
guarantee that the error is non NULL. Fixed in the patch.
Comment 1 Stef Walter 2012-11-29 13:16:43 UTC 
Created attachment 230181 [details] [review]
gnutls: Avoid assertion in finish_handshake()
Comment 2 Stef Walter 2012-11-29 13:19:24 UTC 
Created attachment 230182 [details] [review]
gnutls: Avoid assertion in finish_handshake()

Errrr, wrong patch.
Comment 3 Dan Winship 2012-11-29 15:48:50 UTC 
Comment on attachment 230182 [details] [review]
gnutls: Avoid assertion in finish_handshake()

ok (but maybe fix the tabs-vs-spaces issue on the GError declaration line)
Comment 4 Stef Walter 2012-11-29 21:58:52 UTC 
Attachment 230182 [details] pushed as 8eb8d56 - gnutls: Avoid assertion in finish_handshake()