After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688966 - WindowOverlay: animate the close button together with the border
WindowOverlay: animate the close button together with the border
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-11-24 03:09 UTC by Giovanni Campagna
Modified: 2012-11-24 17:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
WindowOverlay: animate the close button together with the border (3.37 KB, patch)
2012-11-24 03:09 UTC, Giovanni Campagna
committed Details | Review

Description Giovanni Campagna 2012-11-24 03:09:11 UTC
Since the introduction of overlay hover borders, there has a been
a timing disconnection between hiding the border and button, and
this creates noise and reduces the effect of the window+overlay
as a single unit.
Solve that by animating the close button too, so that the two actors
are shown and hidden always at the same time.
Also, consolidate the code to make it clear to future authors that
those two items need to stay coordinated.
Comment 1 Giovanni Campagna 2012-11-24 03:09:14 UTC
Created attachment 229752 [details] [review]
WindowOverlay: animate the close button together with the border
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-11-24 03:20:51 UTC
Review of attachment 229752 [details] [review]:

Looks fine to me.
Comment 3 Giovanni Campagna 2012-11-24 17:56:32 UTC
Attachment 229752 [details] pushed as 96f44e1 - WindowOverlay: animate the close button together with the border