After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688895 - MessageTray: be explicit about removing tweens
MessageTray: be explicit about removing tweens
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-11-22 20:31 UTC by Giovanni Campagna
Modified: 2012-11-22 20:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
MessageTray: be explicit about removing tweens (1.92 KB, patch)
2012-11-22 20:31 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2012-11-22 20:31:19 UTC 
Yes, I got the bug again. I just love this code...
Comment 1 Giovanni Campagna 2012-11-22 20:31:22 UTC 
Created attachment 229657 [details] [review]
MessageTray: be explicit about removing tweens

Turns out that tweener has a very complex logic to decide when a new
tween on the same properties overrides completely the old, and unfortunately
what we were doing was not enough in all cases.
Just be explicit, and don't let anything else mess with the state.
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-11-22 20:33:20 UTC 
Review of attachment 229657 [details] [review]:

I considered this, but thought it would mess with the state machine even more.
Comment 3 Giovanni Campagna 2012-11-22 20:36:32 UTC 
Attachment 229657 [details] pushed as 81cd1e6 - MessageTray: be explicit about removing tweens