GNOME Bugzilla – Bug 688789
Crash on startup
Last modified: 2016-03-31 14:00:39 UTC
gnome-boxes-3.6.2-1.fc18.x86_64 With an existing instance running, run gnome-boxes again. Program received signal SIGSEGV, Segmentation fault. 0x0000000000425600 in boxes_app_suspend_machines (self=0xb3b060) at app.c:3262 3262 _tmp3_ = _tmp2_->items; (gdb) bt
+ Trace 231208
(gdb) list 3257 _tmp0_ = g_main_context_new (); 3258 context = _tmp0_; 3259 _tmp1_ = context; 3260 g_main_context_push_thread_default (_tmp1_); 3261 _tmp2_ = self->collection; 3262 _tmp3_ = _tmp2_->items; 3263 _tmp4_ = _tmp3_->pdata; 3264 _tmp4__length1 = (gint) _tmp3_->len; 3265 { 3266 BoxesCollectionItem** item_collection = NULL;
Created attachment 229564 [details] [review] Don't crash when running Boxes while it's already running When running Boxes while an instance is already running, the new instance crashes in App::suspend_machines. This happens because App::collection is null and App::suspend_machines tries to dereference it. This commit just silently exits from App::suspend_machines in such situations as there will be no machines to save anyway.
Review of attachment 229564 [details] [review]: ack
Comment on attachment 229564 [details] [review] Don't crash when running Boxes while it's already running This has been committed a long time ago. :)