After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688696 - missing dependency - xcb-dri2
missing dependency - xcb-dri2
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: module sets
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2012-11-20 03:22 UTC by darkxst
Modified: 2012-11-21 22:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
moduleset: add missing dep on xcb-dri2 for gnome-shell (808 bytes, patch)
2012-11-20 03:23 UTC, darkxst
needs-work Details | Review
yes I did test, but I missed the other file in my commit. Updated. (1.36 KB, patch)
2012-11-20 20:26 UTC, darkxst
reviewed Details | Review
moduleset: add missing dep on xcb-dri2 for cogl (1.38 KB, patch)
2012-11-20 21:37 UTC, darkxst
committed Details | Review

Description darkxst 2012-11-20 03:22:36 UTC
gnome-shell now fails too build due to missing dependency on xcb-dri2, which 'jhbuild sysdeps' does not pick up, so I had to manually install the package.
Comment 1 darkxst 2012-11-20 03:23:02 UTC
Created attachment 229438 [details] [review]
moduleset: add missing dep on xcb-dri2 for gnome-shell
Comment 2 Colin Walters 2012-11-20 15:29:30 UTC
Review of attachment 229438 [details] [review]:

I don't think that works...there is no xcb-dri2 in the moduleset as far as I can see.  Did you actually test this or are you patching blindly?

I'd need to see a full build log to know what to do for this, but I believe this change is incorrect.
Comment 3 darkxst 2012-11-20 20:26:50 UTC
Created attachment 229504 [details] [review]
yes I did test, but I missed the other file in my commit. Updated.

moduleset: add missing dep on xcb-dri2 for gnome-shell
Comment 4 Colin Walters 2012-11-20 20:43:38 UTC
Review of attachment 229504 [details] [review]:

Ok, this is looking better.    Except I don't see gnome-shell having any dependency on xcb-dri2 from a quick "git grep".  I'm guessing it's some other module that has the dependency.  What is the exact error message from which module?
Comment 5 darkxst 2012-11-20 21:33:42 UTC
Here is the error message, actually module was cogl.


checking for COGL_DEP... yes
checking for COGL_DEP_GL... no
configure: error: Package requirements ( gl) were not met:

Package xcb-dri2 was not found in the pkg-config search path.
Perhaps you should add the directory containing `xcb-dri2.pc'
to the PKG_CONFIG_PATH environment variable
Package 'xcb-dri2', required by 'gl', not found
Comment 6 darkxst 2012-11-20 21:37:46 UTC
Created attachment 229510 [details] [review]
moduleset: add missing dep on xcb-dri2 for cogl
Comment 7 darkxst 2012-11-20 21:41:32 UTC
or actually should the dependency go under the "gl" systemmodule?
Comment 8 Colin Walters 2012-11-20 22:47:13 UTC
Review of attachment 229510 [details] [review]:

This looks fine to me.  Do you have GNOME commit access?
Comment 9 darkxst 2012-11-20 23:12:06 UTC
no I don't have commit access. Can you commit it for me, thanks.
Comment 10 Colin Walters 2012-11-21 22:03:00 UTC
Attachment 229510 [details] pushed as 34304d9 - moduleset: add missing dep on xcb-dri2 for cogl