GNOME Bugzilla – Bug 688525
add keywords to the desktop file
Last modified: 2012-11-23 16:52:25 UTC
Created attachment 229226 [details] [review] patch This patch makes the application search simple and user friendly.
+_Keywords=solitaire;cards;sol;card game;Klondike solitaire; Does gnome-shell search match the whole strings here, or wordwise? Because if it's per word, there wouldn't be a need to add "Klondike solitaire", just "Klondike" would do. Also, why only add a keyword for that one game, instead of the names of all included games (would need to autogenerate this file). Finally, I don't think "sol" is a good keyword.
I included only klondike since that one of the most famous games that people might search for. sol is included since solitaire is also popularly known by the term sol.
(In reply to comment #2) > I included only klondike since that one of the most famous games that people > might search for. Spider is also pretty popular... > sol is included since solitaire is also popularly known by the term sol. [Citation needed] :-)
Created attachment 229239 [details] [review] updated patch
> Spider is also pretty popular... This is included in the updated patch. > > > sol is included since solitaire is also popularly known by the term sol. > > [Citation needed] :-) http://www.linuxfromscratch.org/blfs/view/svn/gnome/aisleriot.html sol is removed from the keyword as it comes in solitaire itself.
We no longer have a separate shortcut for Freecell, right? Might also make sense to add that one. (And then cut it off there because we really don't want every game in the keywords.)
Yes, the freecell desktop file was removed in bug 681645.
Created attachment 229272 [details] [review] updated keywords patch
From: "B.Prathibha" <prathibhab@cdac.in> Use the full name in Author line, please, no abbreviations. Also, should add "patience" to the keywords. With those fixed, ok to commit to master.
Created attachment 229645 [details] [review] keywords patch The patch is updated as per the review suggestions.
(In reply to comment #10) > Created an attachment (id=229645) [details] [review] > keywords patch > > The patch is updated as per the review suggestions. Hi Linda, we spoke in #gnome-love earlier. The patch needs Firstname Lastname in the From field in the patch so you can be correctly credited for the fix.
> Hi Linda, we spoke in #gnome-love earlier. > The patch needs Firstname Lastname in the From field in the patch so you can be > correctly credited for the fix. I don't have a last name. Can I mention my name as initial firstname.
Committed; thanks for the patch!