After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688516 - add keywords to the desktop file
add keywords to the desktop file
Status: RESOLVED FIXED
Product: gnome-screenshot
Classification: Core
Component: general
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-screenshot-maint
gnome-screenshot-maint
Depends on:
Blocks:
 
 
Reported: 2012-11-17 07:12 UTC by B.Prathibha
Modified: 2013-01-03 10:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (610 bytes, text/plain)
2012-11-17 07:12 UTC, B.Prathibha
  Details
patch (701 bytes, text/plain)
2012-11-17 07:57 UTC, B.Prathibha
  Details
patch (743 bytes, patch)
2012-11-17 08:06 UTC, B.Prathibha
needs-work Details | Review
updated patch (793 bytes, patch)
2012-11-20 01:28 UTC, B.Prathibha
needs-work Details | Review
keywords patch (1.51 KB, patch)
2012-11-27 02:29 UTC, B.Prathibha
needs-work Details | Review
Patch fixed (704 bytes, patch)
2013-01-01 18:31 UTC, Daniel Mustieles
accepted-commit_now Details | Review

Description B.Prathibha 2012-11-17 07:12:17 UTC
Created attachment 229214 [details]
patch

This makes gnome-shell more powerful.
Comment 1 B.Prathibha 2012-11-17 07:57:04 UTC
Created attachment 229216 [details]
patch
Comment 2 B.Prathibha 2012-11-17 08:06:43 UTC
Created attachment 229217 [details] [review]
patch
Comment 3 André Klapper 2012-11-17 12:55:12 UTC
I don't see how using four times "screen" makes sense...
+_Keywords=screen capture;print screen;screenshot;screen printing;
Comment 4 Cosimo Cecchi 2012-11-19 16:43:11 UTC
Review of attachment 229217 [details] [review]:

::: src/gnome-screenshot.desktop.in
@@ +2,3 @@
 _Name=Screenshot
 _Comment=Save images of your screen or individual windows
+_Keywords=screen capture;print screen;screenshot;screen printing;

I think the idea is to have this as a set of words, not sentences.
I'd go for "snapshot;screenshot;capture;print;"
Comment 5 B.Prathibha 2012-11-20 01:28:44 UTC
Created attachment 229430 [details] [review]
updated patch
Comment 6 B.Prathibha 2012-11-20 01:31:22 UTC
As per the comments the patch is updated. Also removed screenshot from the Keywords as it appears in the Name itself.
Comment 7 Cosimo Cecchi 2012-11-26 19:08:36 UTC
Comment on attachment 229430 [details] [review]
updated patch

Thanks for the update - patches should always be attached here against git master though, not on top one another after review. Could you reattach the whole patch against git?
Comment 8 André Klapper 2012-11-27 01:27:40 UTC
Also see https://live.gnome.org/Git/Developers ...
Comment 9 B.Prathibha 2012-11-27 02:29:13 UTC
Created attachment 229967 [details] [review]
keywords patch

Whole patch - reattached.
Comment 10 Daniel Mustieles 2013-01-01 18:20:05 UTC
Is the last patch ok? It seems it has some garbage from previous commits... could somebody please review it?
Comment 11 André Klapper 2013-01-01 18:25:55 UTC
Comment on attachment 229967 [details] [review]
keywords patch

No, the last patch is not okay. It should be merged instead of two patches in one file.
Comment 12 Daniel Mustieles 2013-01-01 18:31:34 UTC
Created attachment 232455 [details] [review]
Patch fixed
Comment 13 Matthias Clasen 2013-01-02 04:31:43 UTC
looks good to me
Comment 14 Cosimo Cecchi 2013-01-02 13:19:32 UTC
Review of attachment 232455 [details] [review]:

Looks good.
Comment 15 Daniel Mustieles 2013-01-03 10:01:08 UTC
Done.

Thanks!