GNOME Bugzilla – Bug 688516
add keywords to the desktop file
Last modified: 2013-01-03 10:01:08 UTC
Created attachment 229214 [details] patch This makes gnome-shell more powerful.
Created attachment 229216 [details] patch
Created attachment 229217 [details] [review] patch
I don't see how using four times "screen" makes sense... +_Keywords=screen capture;print screen;screenshot;screen printing;
Review of attachment 229217 [details] [review]: ::: src/gnome-screenshot.desktop.in @@ +2,3 @@ _Name=Screenshot _Comment=Save images of your screen or individual windows +_Keywords=screen capture;print screen;screenshot;screen printing; I think the idea is to have this as a set of words, not sentences. I'd go for "snapshot;screenshot;capture;print;"
Created attachment 229430 [details] [review] updated patch
As per the comments the patch is updated. Also removed screenshot from the Keywords as it appears in the Name itself.
Comment on attachment 229430 [details] [review] updated patch Thanks for the update - patches should always be attached here against git master though, not on top one another after review. Could you reattach the whole patch against git?
Also see https://live.gnome.org/Git/Developers ...
Created attachment 229967 [details] [review] keywords patch Whole patch - reattached.
Is the last patch ok? It seems it has some garbage from previous commits... could somebody please review it?
Comment on attachment 229967 [details] [review] keywords patch No, the last patch is not okay. It should be merged instead of two patches in one file.
Created attachment 232455 [details] [review] Patch fixed
looks good to me
Review of attachment 232455 [details] [review]: Looks good.
Done. Thanks!