After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688511 - Windows compilers without pthreads still have testrtpool.c being built in tests
Windows compilers without pthreads still have testrtpool.c being built in tests
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
1.0.2
Other Windows
: Normal normal
: 1.0.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-11-17 05:41 UTC by Michael Esemplare
Modified: 2012-11-17 10:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to allow cross compile for windows build without pthreads (915 bytes, patch)
2012-11-17 05:41 UTC, Michael Esemplare 		none Details | Review

Description Michael Esemplare 2012-11-17 05:41:20 UTC 
Created attachment 229208 [details] [review]
Patch to allow cross compile for windows build without pthreads

Affects: v1.0.2, branch 1.0, and master

I have attached a patch that allows me to successfully build. I can not verify that it doesn't break things for people who use pthreads.

Make output:

make -C manual
make[4]: Entering directory `/home/src/git/gst/gstreamer/tests/examples/manual'
make  all-am
make[5]: Entering directory `/home/src/git/gst/gstreamer/tests/examples/manual'
  CC     elementcreate.o
  CCLD   elementcreate.exe
  ...
  ...
  CC     testrtpool-testrtpool.o
testrtpool.c:30:21: fatal error: pthread.h: No such file or directory
compilation terminated.
make[5]: *** [testrtpool-testrtpool.o] Error 1
make[5]: Leaving directory `/home/src/git/gst/gstreamer/tests/examples/manual'
make[4]: *** [all] Error 2
make[4]: Leaving directory `/home/src/git/gst/gstreamer/tests/examples/manual'
make[3]: *** [manual] Error 2
make[3]: Leaving directory `/home/src/git/gst/gstreamer/tests/examples'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/src/git/gst/gstreamer/tests'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/src/git/gst/gstreamer'
make: *** [all] Error 2
Comment 1 Tim-Philipp Müller 2012-11-17 10:56:12 UTC 
Many thanks for the patch, will be fixed in the next release.

Please set your real name in the bugzilla preferences as well, so we can attribute your contributions properly (for non-trivial patches this is a requirement), thanks!


commit 82c7b2da5133052198d40aa8fe7ed277e0db958a
Author: Tim-Philipp Müller <tim@centricular.net>
Date:   Sat Nov 17 10:27:11 2012 +0000

    examples: don't compile testrtpool example if pthreads are not available like on win32
    
    Based on patch by: italarab@gmail.com
    
    https://bugzilla.gnome.org/show_bug.cgi?id=688511