After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688469 - Link to mouse panel
Link to mouse panel
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Wacom
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: Joaquim Rocha
Control-Center Maintainers
Depends on:
Blocks: 698119
 
 
Reported: 2012-11-16 15:07 UTC by Bastien Nocera
Modified: 2013-04-16 10:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (3.71 KB, patch)
2012-12-05 10:15 UTC, Olivier Fourdan 		none Details | Review
Updated patch (5.79 KB, patch)
2012-12-05 10:18 UTC, Olivier Fourdan 		needs-work Details | Review
Small tweak to Olivier's patch (5.46 KB, patch)
2013-04-11 11:41 UTC, Joaquim Rocha 		accepted-commit_now Details | Review

Description Bastien Nocera 2012-11-16 15:07:26 UTC 
For tablets that can have a mouse (note, things like Cintiqs wouldn't have one), add a link to the mouse panel.

Putting it in the same place as the "Adjust display resolution" link is probably the best thing to do.
Comment 1 Olivier Fourdan 2012-12-05 10:15:46 UTC 
Created attachment 230747 [details] [review]
Proposed patch
Comment 2 Olivier Fourdan 2012-12-05 10:18:06 UTC 
Created attachment 230748 [details] [review]
Updated patch

Sorry my bad, previous patch was incomplete
Comment 3 Bastien Nocera 2012-12-05 10:36:46 UTC 
Review of attachment 230748 [details] [review]:

Works well, though I think there's too much of a gap between the link and the buttons above.

In test-wacom, compare the height of the whitespace above the "adjust display settings" and above the "mouse settings" button.
Comment 4 Bastien Nocera 2013-04-04 12:37:33 UTC 
Maintainer change
Comment 5 Joaquim Rocha 2013-04-04 16:59:40 UTC 
Review of attachment 230748 [details] [review]:

I took looked into it and I believe that just replacing the top-attach property of the UI patch from 4 to 3 makes it closer to the buttons as Bastien suggests.

This patch didn't apply cleanly to the upstream version. I can commit this replacing the author info to Olivier's and then do a small patch to change that line or change the line directly (but it wouldn't be Olivier's original patch).

Either way is good to me so let me know what you think is the best aproach.
Comment 6 Bastien Nocera 2013-04-04 21:50:46 UTC 
Can you please post the patch for review?
Comment 7 Joaquim Rocha 2013-04-11 11:41:28 UTC 
Created attachment 241245 [details] [review]
Small tweak to Olivier's patch

Sorry for the delay.

I'm attaching Olivier's patch with the changes I mentioned to make it look a bit better.
Comment 8 Bastien Nocera 2013-04-15 17:39:12 UTC 
Review of attachment 241245 [details] [review]:

This is better, though there's alignment problems now.

This is immediately visible in test-wacom. On the first page, the first section is now bigger than the icon on the left hand-side. This means that the 2nd page (the one for the cintiq) has a lot of whitespace underneath the stylus section.

This can be fixed in a separate bug (file it before closing this one).
Comment 9 Joaquim Rocha 2013-04-16 10:17:11 UTC 
Hadn't noticed those alignment problems, sorry.

Here's the new bug: https://bugzilla.gnome.org/show_bug.cgi?id=698119
Comment 10 Joaquim Rocha 2013-04-16 10:34:47 UTC 
Pushed to master.