GNOME Bugzilla – Bug 688350
Layout switch does not work smoothly
Last modified: 2013-04-17 11:27:53 UTC
When input sources switcher shortcut is set to "caps lock" via gnome-tweak-tool sometimes switch does not happen and caps lock works like caps lock (i.e. locks capitals mode). It's very annoying, and makes this all input sources stuff unusable. xorg.conf settings with keyboard plugin removed work much, much better. It looks like keyboard plugin tries to hook caps presses, but sometimes it fails.
Severity is critical because gnome-3.6 is not usable for international users. It's a _critical_ issue, and it annoys everyone who has multiple keyboard layouts. Please fix it ASAP otherwise some users will be lost for you.
Created attachment 229032 [details] [review] keyboard: Trigger input source switching on key press for Caps Lock We usually only trigger the switch on key release because we don't want to prevent applications from getting e.g. Ctrl+Shift+E if the shortcut is Ctrl+Shift. But, for shortcuts including Caps Lock we can trigger the switch on key press since applications don't usually include Caps Lock in their own shortcuts and this allows us to: 1) be more resposive; 2) trigger the switch even if the user is typing quickly and thus we are getting other key events; 3) reduce the time window during which the lock mask is active in the server. -- Does this patch make it work better for you? (In reply to comment #1) > Severity is critical because gnome-3.6 is not usable for international users. > It's a _critical_ issue, and it annoys everyone who has multiple keyboard > layouts. Please fix it ASAP otherwise some users will be lost for you. Can you please leave the drama and this kind of menacing out of bugzilla? Thanks.
Review of attachment 229032 [details] [review]: Code looks fine. Do you have something to guard against key repeats though? (not sure if CapsLock triggers repeats),
(In reply to comment #2) > Does this patch make it work better for you? Yes, it does. Thank you very much! > (In reply to comment #1) > > Severity is critical because gnome-3.6 is not usable for international users. > > It's a _critical_ issue, and it annoys everyone who has multiple keyboard > > layouts. Please fix it ASAP otherwise some users will be lost for you. > > Can you please leave the drama and this kind of menacing out of > bugzilla? Thanks. Ok, please don't treat my complains as menacing, I'm very sorry if it insults you.
(In reply to comment #3) > Review of attachment 229032 [details] [review]: > > Code looks fine. Do you have something to guard against key repeats though? > (not sure if CapsLock triggers repeats), None of CapsLock, Shift, Ctrl or Alt do key repeats.
Looks good then.
Attachment 229032 [details] pushed as ef29fcf - keyboard: Trigger input source switching on key press for Caps Lock
It's better, but not perfect, layout switching still does not happen sometimes. For example in alt+f2 dialog. That's only an example, but not the only place where switch does not happen. However I can't find pattern :( Sometimes it happens in skype, sometimes in chromium. What's interesting - it happens more often if I type fast, if I type slowly it works. Maybe it does not switch if there's some other key is still pressed? Btw, if I type with pressed caps lock it acts as shift (i.e. produces capital letters), it should not happen, but it's another bug.
Let's keep this one closed. Further improvements can be tracked in bug 697002.